Skip to content

[SPARK-55814][SQL] Add proper error class and SQL state for defineTempViewWithIfNotExistsError #54594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miland-db wants to merge 3 commits into
base: master
Choose a base branch
from
+16 −10
Open

[SPARK-55814][SQL] Add proper error class and SQL state for defineTempViewWithIfNotExistsError #54594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33fafa5
Init commit
miland-db Mar 3, 2026
d59763f
Update sqlstate
miland-db Mar 3, 2026
1b1c4fb
trigger CI
miland-db Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions common/utils/src/main/resources/error/error-conditions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6395,6 +6395,12 @@
],
"sqlState" : "42P07"
},
"TEMP_VIEW_IF_NOT_EXISTS_NOT_ALLOWED" : {
"message" : [
"It is not allowed to define a TEMPORARY view with IF NOT EXISTS."
],
"sqlState" : "0A000"
},
"TEMP_VIEW_NAME_TOO_MANY_NAME_PARTS" : {
"message" : [
"CREATE TEMPORARY VIEW or the corresponding Dataset APIs only accept single-part view names, but got: <actualName>."
Expand Down Expand Up @@ -8022,11 +8028,6 @@
"CREATE VIEW with both IF NOT EXISTS and REPLACE is not allowed."
]
},
"_LEGACY_ERROR_TEMP_0053" : {
"message" : [
"It is not allowed to define a TEMPORARY view with IF NOT EXISTS."
]
},
"_LEGACY_ERROR_TEMP_0056" : {
"message" : [
"Invalid time travel spec: <reason>."
Expand Down
2 changes: 1 addition & 1 deletion sql/api/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,7 @@ private[sql] object QueryParsingErrors extends DataTypeErrorsBase {
}

def defineTempViewWithIfNotExistsError(ctx: CreateViewContext): Throwable = {
new ParseException(errorClass = "_LEGACY_ERROR_TEMP_0053", ctx)
new ParseException(errorClass = "TEMP_VIEW_IF_NOT_EXISTS_NOT_ALLOWED", ctx)
}

def notAllowedToAddDBPrefixForTempViewError(
Expand Down
13 changes: 9 additions & 4 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,15 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {

test("error handling: disallow IF NOT EXISTS for CREATE TEMPORARY VIEW") {
withTempView("myabcdview") {
val e = intercept[ParseException] {
sql("CREATE TEMPORARY VIEW IF NOT EXISTS myabcdview AS SELECT * FROM jt")
}
assert(e.message.contains("It is not allowed to define a TEMPORARY view with IF NOT EXISTS"))
val sqlText = "CREATE TEMPORARY VIEW IF NOT EXISTS myabcdview AS SELECT * FROM jt"
checkError(
exception = intercept[ParseException] {
sql(sqlText)
},
condition = "TEMP_VIEW_IF_NOT_EXISTS_NOT_ALLOWED",
parameters = Map.empty,
context = ExpectedContext(sqlText, 0, sqlText.length - 1)
)
}
}

Expand Down