[SPARK-55848][SQL][4.1][FOLLOW-UP] Restore deleted comments#54875
Closed
naveenp2708 wants to merge 1 commit intoapache:branch-4.1from
Closed
[SPARK-55848][SQL][4.1][FOLLOW-UP] Restore deleted comments#54875naveenp2708 wants to merge 1 commit intoapache:branch-4.1from
naveenp2708 wants to merge 1 commit intoapache:branch-4.1from
Conversation
Follow-up to apache#54751. Restores 3 comments that were accidentally deleted during the satisfies0() restructuring.
Author
|
@peter-toth Follow-up to restore deleted comments on branch-4.1 as requested |
szehon-ho
approved these changes
Mar 18, 2026
peter-toth
changed the title
peter-toth
approved these changes
Mar 18, 2026
Contributor
|
As this is just a comment update and the test failures seems unrelated let me merge this PR. |
peter-toth
pushed a commit
that referenced
this pull request
Mar 18, 2026
### What changes were proposed in this pull request? Follow-up to #54751. Restores 3 comments in `satisfies0()` that were accidentally deleted during the restructuring. Comments only, no logic changes. ### Why are the changes needed? Per peter-toth's review in #54851, the original comments should be preserved. ### Does this PR introduce any user-facing change? No. Comments only. ### How was this patch tested? Compilation verified. No logic changes. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #54875 from naveenp2708/spark-55848-restore-comments-4.1. Authored-by: Naveen Kumar Puppala <naveenp2708@gmail.com> Signed-off-by: Peter Toth <peter.toth@gmail.com>
Contributor
|
Thank you @naveenp2708 and @szehon-ho. Merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow-up to #54751. Restores 3 comments in
satisfies0()that were accidentally deleted during the restructuring. Comments only, no logic changes.Why are the changes needed?
Per @peter-toth's review in #54851, the original comments should be preserved.
Does this PR introduce any user-facing change?
No. Comments only.
How was this patch tested?
Compilation verified. No logic changes.
Was this patch authored or co-authored using generative AI tooling?
No.