[SPARK-56205][SS] Validate base state store checkpoint ID before committing microbatch#55008
Closed
ericm-db wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-56205][SS] Validate base state store checkpoint ID before committing microbatch#55008ericm-db wants to merge 1 commit intoapache:masterfrom
ericm-db wants to merge 1 commit intoapache:masterfrom
Conversation
…atch ## Summary - Validate that the executor-reported `baseStateStoreCkptId` matches the checkpoint ID the driver originally sent (`currentStateStoreCkptId`) before accepting the microbatch commit - Add `STATE_STORE_BASE_CHECKPOINT_ID_MISMATCH` error class with `StateStoreBaseCheckpointIdMismatch` exception - Replace the `// TODO validate baseStateStoreCkptId` in `MicroBatchExecution.updateStateStoreCkptIdForOperator` with validation logic ## Test plan - Add integration test verifying `baseStateStoreCkptId` matches commit log across batches within a single stream run - Add integration test verifying `baseStateStoreCkptId` matches commit log across stream stop/restart (exercises the `populateStartOffsets` commit log recovery path) - Add unit test verifying `StateStoreBaseCheckpointIdMismatch` error class produces correct error condition and message Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ericm-db
changed the title
bothra90
approved these changes
Mar 25, 2026
anishshri-db
approved these changes
Mar 25, 2026
Contributor
|
LGTM pending CI |
Contributor
|
@ericm-db |
Contributor
|
Docker failures only - should not be related |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
baseStateStoreCkptIdmatches the checkpoint ID the driver originally sent (currentStateStoreCkptId) before accepting the microbatch commitSTATE_STORE_BASE_CHECKPOINT_ID_MISMATCHerror class withStateStoreBaseCheckpointIdMismatchexception// TODO validate baseStateStoreCkptIdinMicroBatchExecution.updateStateStoreCkptIdForOperatorwith validation logicWhy are the changes needed?
To ensure that we have the right lineage of checkpoint files
Does this PR introduce any user-facing change?
No
How was this patch tested?
baseStateStoreCkptIdmatches commit log across batches within a single stream runbaseStateStoreCkptIdmatches commit log across stream stop/restart (exercises thepopulateStartOffsetscommit log recovery path)StateStoreBaseCheckpointIdMismatcherror class produces correct error condition and messageWas this patch authored or co-authored using generative AI tooling?
Generated by: Claude Opus 4.6