[SPARK-56220][PYTHON] Add utility to check wrongly used errorClass in Python#55022
Draft
gaogaotiantian wants to merge 4 commits intoapache:masterfrom
Draft
[SPARK-56220][PYTHON] Add utility to check wrongly used errorClass in Python#55022gaogaotiantian wants to merge 4 commits intoapache:masterfrom
gaogaotiantian wants to merge 4 commits intoapache:masterfrom
Conversation
Member
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the utility to parse source code to look for custom exceptions with error classes and check if the errorClass exists, also whether the messageParameters are valid.
Why are the changes needed?
LLM is especially good at this kind of hallucination. Turns out we have more than one place in our code base where a non-exist
errorClassis used, or some randommessageParametersare used.We had a very simple string based check to see if the exception itself is valid. This PR introduced an
astbased method to check the actual arguments in the exception.Does this PR introduce any user-facing change?
No.
How was this patch tested?
I found several issues in our code based and fixed them in this PR. One of the issues is special so I made a separate fix in #55020
Was this patch authored or co-authored using generative AI tooling?
No.