[SPARK-56247][PYTHON] Fix the fall back behavior and type hint of inheritable_thread_target#55043
Closed
gaogaotiantian wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-56247][PYTHON] Fix the fall back behavior and type hint of inheritable_thread_target#55043gaogaotiantian wants to merge 2 commits intoapache:masterfrom
gaogaotiantian wants to merge 2 commits intoapache:masterfrom
Conversation
zhengruifeng
approved these changes
Mar 27, 2026
Contributor
|
merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Nonefrom the possible input type hintfis a session, return a decorator instead offif pinned thread mode is offWhy are the changes needed?
Th input
fcan't beNone- we have no logic to deal with it. Also as a decorator, the way it works is to deal withbut we need special logic for this - we don't have that.
When pinned-thread mode is off (legacy, we don't care much, but still nice to have it right), we need
@inheritable_thread_target(session)to be ano-op, instead of returnsessiondirectly, which will raise an exception when we dosession(f).Does this PR introduce any user-facing change?
Not really, we are fixing an unexpected behavior.
How was this patch tested?
CI should pass. We don't really care too much about the legacy behavior though.
Was this patch authored or co-authored using generative AI tooling?
No.