[SPARK-56250][SQL][FOLLOWUP][4.1] Remove confusing defensive code in SortExec.rowSorter and add warning comment#55098
Closed
viirya wants to merge 1 commit intoapache:branch-4.1from
Closed
Conversation
dongjoon-hyun
approved these changes
Mar 30, 2026
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you for quick fixing, @viirya .
dongjoon-hyun
changed the title
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 30, 2026
…SortExec.rowSorter and add warning comment ### What changes were proposed in this pull request? #55048 was backported to 4.1 but there is an error when resolving the conflicts. This patch fixes it. ### Why are the changes needed? Restoring the build of 4.1. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test ### Was this patch authored or co-authored using generative AI tooling? No Closes #55098 from viirya/revert-sort-exec-defensive-code-4.1. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Merged to branch-4.1. |
Member
Author
|
Thank you @dongjoon-hyun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#55048 was backported to 4.1 but there is an error when resolving the conflicts. This patch fixes it.
Why are the changes needed?
Restoring the build of 4.1.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test
Was this patch authored or co-authored using generative AI tooling?
No