[SPARK-56361][SS] Provide better error with logging on NPE in stream-stream join#55214
Closed
HeartSaVioR wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-56361][SS] Provide better error with logging on NPE in stream-stream join#55214HeartSaVioR wants to merge 2 commits intoapache:masterfrom
HeartSaVioR wants to merge 2 commits intoapache:masterfrom
Conversation
zeruibao
approved these changes
Apr 6, 2026
Contributor
zeruibao
left a comment
zeruibao
left a comment
There was a problem hiding this comment.
Thanks for this change. Looks nice!
anishshri-db
approved these changes
Apr 6, 2026
Contributor
Author
|
Thanks! Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to provide better error with additional logging on NPE in stream-stream join.
We have captured several places which could throw NPE - this PR provides the better error for users which is less cryptic and gives a quick mitigation if they are willing to tolerate losing some data to keep the query running. For devs, this PR leaves the context to the log, so that when users come to devs with the error, devs can at least know where to start looking into.
Why are the changes needed?
Throwing NPE does not help anything for users and devs. For users, NPE is mostly cryptic error and they know nothing what to do to mitigate the issue. There is no information around context, so debugging is almost impossible for devs when this happens.
Does this PR introduce any user-facing change?
Yes, users would no longer get NPE from stream-stream join for known places on potential NPE, and will get better exception with the guidance for quick mitigation (toleration of data loss).
How was this patch tested?
Modified test
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude 4.6 Opus