[SPARK-56372][INFRA][4.0] Add cmake to CI Docker images for R fs package compilation#55255
Closed
zhengruifeng wants to merge 3 commits intoapache:branch-4.0from
Closed
[SPARK-56372][INFRA][4.0] Add cmake to CI Docker images for R fs package compilation#55255zhengruifeng wants to merge 3 commits intoapache:branch-4.0from
zhengruifeng wants to merge 3 commits intoapache:branch-4.0from
Conversation
…ompilation Add `cmake` to the `apt-get install` list in CI Docker images (`docs`, `lint`, `sparkr`). The R `fs` package (a transitive dependency of `devtools`, `testthat`, `rmarkdown`) now bundles `libuv v1.52.0`, which requires `cmake` to build. This causes the "Base image build" job to fail with: ``` /bin/bash: line 2: cmake: command not found make: *** [Makevars:44: libuv] Error 127 ERROR: compilation failed for package 'fs' ``` The `fs` compilation failure cascades into: `sass` → `bslib` → `shiny` → `rmarkdown` → `devtools` → `testthat`, breaking the entire R package installation. See https://github.com/apache/spark/actions/runs/24067715329/job/70197367201 No. CI should pass with the updated Docker images. Co-authored-by: Claude code (Opus 4.6) Closes apache#55233 from zhengruifeng/fix_imsage. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
zhengruifeng
changed the title
allisonwang-db
approved these changes
Apr 8, 2026
HyukjinKwon
approved these changes
Apr 9, 2026
Installing preferably upgrades pkgdown to the latest version as a dependency. The latest pkgdown includes build_llm_docs which fails with the old pandoc on Ubuntu 22.04. Fix by swapping install order so pkgdown 2.0.1 is installed last with upgrade='never'.
zhengruifeng
added a commit
that referenced
this pull request
Apr 9, 2026
…age compilation This is a cherry-pick of c869549 for branch-4.0. ### What changes were proposed in this pull request? Add `cmake` to the `apt-get install` list in CI Docker images (`docs`, `lint`, `sparkr`). ### Why are the changes needed? The R `fs` package (a transitive dependency of `devtools`, `testthat`, `rmarkdown`) now bundles `libuv v1.52.0`, which requires `cmake` to build. This causes the "Base image build" job to fail with: ``` /bin/bash: line 2: cmake: command not found make: *** [Makevars:44: libuv] Error 127 ERROR: compilation failed for package 'fs' ``` The `fs` compilation failure cascades into: `sass` → `bslib` → `shiny` → `rmarkdown` → `devtools` → `testthat`, breaking the entire R package installation. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI should pass with the updated Docker images. ### Was this patch authored or co-authored using generative AI tooling? Co-authored-by: Claude code (Opus 4.6) Closes #55255 from zhengruifeng/cherry-pick-4.0. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com>
Contributor
Author
|
thanks, merged to 4.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of c869549 for branch-4.0.
What changes were proposed in this pull request?
Add
cmaketo theapt-get installlist in CI Docker images (docs,lint,sparkr).Why are the changes needed?
The R
fspackage (a transitive dependency ofdevtools,testthat,rmarkdown) now bundleslibuv v1.52.0, which requirescmaketo build. This causes the "Base image build" job to fail with:The
fscompilation failure cascades into:sass→bslib→shiny→rmarkdown→devtools→testthat, breaking the entire R package installation.Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI should pass with the updated Docker images.
Was this patch authored or co-authored using generative AI tooling?
Co-authored-by: Claude code (Opus 4.6)