[SPARK-56391] [SQL] Support unwrap string type to date type in UnwrapCastInBinaryComparison#55257
Open
daijy wants to merge 4 commits intoapache:masterfrom
Open
[SPARK-56391] [SQL] Support unwrap string type to date type in UnwrapCastInBinaryComparison#55257daijy wants to merge 4 commits intoapache:masterfrom
daijy wants to merge 4 commits intoapache:masterfrom
Conversation
c701e3b to
d2bb836
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve the existing UnwrapCastInBinaryComparison to unwrap string to date, ie. cast(date_key_string as date)=date_literal_constant => date_key_string=cast(date_literal_constant, string)
Why are the changes needed?
Spark fail to push date_key_string=date_literal_constant condition to iceberg table, this works fine for parquet table (date_key is a string partition column):
The reason is Spark add a cast on the left side to cast string to date. The cast expression pushed to iceberg data source which is not able to process. A workaround is to add cast on right side, ie. cast date to string.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test
Was this patch authored or co-authored using generative AI tooling?
claude-4.5-sonnet