[SPARK-56513][INFRA] Pin meson<1.11.0 and lxml==4.9.4 in Dockerfile for PyPy to recover CI#55369
[SPARK-56513][INFRA] Pin meson<1.11.0 and lxml==4.9.4 in Dockerfile for PyPy to recover CI#55369sarutak wants to merge 1 commit intoapache:masterfrom
meson<1.11.0 and lxml==4.9.4 in Dockerfile for PyPy to recover CI#55369Conversation
meson<1.11.0 and lxml==4.9.4 to recover CI.meson<1.11.0 and lxml==4.9.4 in Dockerfile for PyPy to recover CI.
|
|
meson<1.11.0 and lxml==4.9.4 in Dockerfile for PyPy to recover CI.meson<1.11.0 and lxml==4.9.4 in Dockerfile for PyPy to recover CI
|
|
|
pypy support is already dropped. Let me check how we should proceed with it. |
|
I believe we can just remove all the pypy related part from infra image - they are not used anymore. |
|
thanks, merged to master |
+1, the pypy should at least not affect the master branch |
|
should this(and other recent similar changes) be backported? I see that at least branch-4.1 and branch-4.0 infra image jobs are broken now. |
It seems that the issue resolved by #55414 is also occurring with |
|
we can backport SPARK-56540 , I'll handle this later. |
| ln -sf /usr/local/pypy/pypy3.10/bin/pypy /usr/local/bin/pypy3 | ||
| RUN curl -sS https://bootstrap.pypa.io/get-pip.py | pypy3 | ||
| RUN pypy3 -m pip install numpy 'six==1.16.0' 'pandas==2.3.3' scipy coverage matplotlib lxml | ||
| RUN echo 'meson<1.11.0' > /tmp/constraints.txt && \ |
There was a problem hiding this comment.
This is unfortunate to use < rather than blocking a single "bad" release. It was fixed in meson==1.11.1
There was a problem hiding this comment.
Thank you for pointing it out. That has been removed.
#55505
… code ### What changes were proposed in this pull request? This PR removes remaining PyPy related code. ### Why are the changes needed? It's almost done in #54988 but there are still a few left and suggested to remove them #55369 (comment) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #55505 from sarutak/remove-pypy. Authored-by: Kousuke Saruta <sarutak@amazon.co.jp> Signed-off-by: Kousuke Saruta <sarutak@apache.org>
What changes were proposed in this pull request?
This PR pin
meson<1.11.0andlxml==4.9.4to recover CI.Why are the changes needed?
Recently, CI fails due to docker image building failure.
https://github.com/apache/spark/actions/runs/24489111484/job/71571576157
The root causes are:
1.11.0was recently released and pandas 2.3.3 can not be built with it (BUILD: Fails with meson 1.11.0 pandas-dev/pandas#65252)4.9.4to consistent with the version specified in.github/workflows/build_and_test.yml.Without pinning
lxml,docker buildwill fail with following error.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Confirmed that
docker buildworks for bothdev/infra/Dockerfileanddev/spark-test-image/pypy-310/DockerfileWas this patch authored or co-authored using generative AI tooling?
No.