Skip to content

[SPARK-56513][INFRA] Pin meson<1.11.0 and lxml==4.9.4 in Dockerfile for PyPy to recover CI#55369

Closed
sarutak wants to merge 1 commit intoapache:masterfrom
sarutak:pin-meson-lxml
Closed

[SPARK-56513][INFRA] Pin meson<1.11.0 and lxml==4.9.4 in Dockerfile for PyPy to recover CI#55369
sarutak wants to merge 1 commit intoapache:masterfrom
sarutak:pin-meson-lxml

Conversation

@sarutak
Copy link
Copy Markdown
Member

@sarutak sarutak commented Apr 16, 2026

What changes were proposed in this pull request?

This PR pin meson<1.11.0 and lxml==4.9.4 to recover CI.

Why are the changes needed?

Recently, CI fails due to docker image building failure.
https://github.com/apache/spark/actions/runs/24489111484/job/71571576157

The root causes are:

Without pinning lxml, docker build will fail with following error.

538.3 Collecting lxml
538.3   Downloading lxml-6.0.4.tar.gz (4.2 MB)
538.4      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 4.2/4.2 MB 91.5 MB/s  0:00:00
538.7   Installing build dependencies: started
540.6   Installing build dependencies: finished with status 'done'
540.6   Getting requirements to build wheel: started
541.3   Getting requirements to build wheel: finished with status 'error'
541.3   error: subprocess-exited-with-error
541.3
541.3   × Getting requirements to build wheel did not run successfully.
541.3   │ exit code: 1
541.3   ╰─> [3 lines of output]
541.3       Building lxml version 6.0.4.
541.3       Building without Cython.
541.3       Error: Please make sure the libxml2 and libxslt development packages are installed.
541.3       [end of output]
541.3
541.3   note: This error originates from a subprocess, and is likely not a problem with pip.
541.3 ERROR: Failed to build 'lxml' when getting requirements to build wheel
------
Dockerfile:67
--------------------
  66 |     RUN curl -sS https://bootstrap.pypa.io/get-pip.py | pypy3
  67 | >>> RUN echo 'meson<1.11.0' > /tmp/constraints.txt && \
  68 | >>>     PIP_CONSTRAINT=/tmp/constraints.txt pypy3 -m pip install numpy 'six==1.16.0' 'pandas==2.3.3' scipy coverage matplotlib lxml && \
  69 | >>>     rm -f /tmp/constraints.txt
  70 |
--------------------

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Confirmed that docker build works for both dev/infra/Dockerfile and dev/spark-test-image/pypy-310/Dockerfile

Was this patch authored or co-authored using generative AI tooling?

No.

@sarutak sarutak changed the title [SPARK-XXXXX][INFRA] Pin meson<1.11.0 and lxml==4.9.4 to recover CI. [SPARK-XXXXX][INFRA] Pin meson<1.11.0 and lxml==4.9.4 in Dockerfile for PyPy to recover CI. Apr 16, 2026
@sarutak
Copy link
Copy Markdown
Member Author

sarutak commented Apr 16, 2026

docker build (apt-get install) on GA seems very slow today...

@sarutak sarutak changed the title [SPARK-XXXXX][INFRA] Pin meson<1.11.0 and lxml==4.9.4 in Dockerfile for PyPy to recover CI. [SPARK-56513][INFRA] Pin meson<1.11.0 and lxml==4.9.4 in Dockerfile for PyPy to recover CI Apr 16, 2026
@sarutak
Copy link
Copy Markdown
Member Author

sarutak commented Apr 16, 2026

@sarutak sarutak marked this pull request as ready for review April 16, 2026 20:12
@gaogaotiantian
Copy link
Copy Markdown
Contributor

pypy support is already dropped. Let me check how we should proceed with it.

@gaogaotiantian
Copy link
Copy Markdown
Contributor

I believe we can just remove all the pypy related part from infra image - they are not used anymore.

@zhengruifeng
Copy link
Copy Markdown
Contributor

thanks, merged to master

@zhengruifeng
Copy link
Copy Markdown
Contributor

I believe we can just remove all the pypy related part from infra image - they are not used anymore.

+1, the pypy should at least not affect the master branch

@pan3793
Copy link
Copy Markdown
Member

pan3793 commented Apr 21, 2026

should this(and other recent similar changes) be backported? I see that at least branch-4.1 and branch-4.0 infra image jobs are broken now.

@sarutak
Copy link
Copy Markdown
Member Author

sarutak commented Apr 21, 2026

@pan3793

should this(and other recent similar changes) be backported? I see that at least branch-4.1 and branch-4.0 infra image jobs are broken now.

It seems that the issue resolved by #55414 is also occurring with branch-4.0 and branch-4.1.
Could you take a look at that, @LuciferYang ?

@LuciferYang
Copy link
Copy Markdown
Contributor

LuciferYang commented Apr 21, 2026

we can backport SPARK-56540 , I'll handle this later.

Comment thread dev/infra/Dockerfile
ln -sf /usr/local/pypy/pypy3.10/bin/pypy /usr/local/bin/pypy3
RUN curl -sS https://bootstrap.pypa.io/get-pip.py | pypy3
RUN pypy3 -m pip install numpy 'six==1.16.0' 'pandas==2.3.3' scipy coverage matplotlib lxml
RUN echo 'meson<1.11.0' > /tmp/constraints.txt && \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunate to use < rather than blocking a single "bad" release. It was fixed in meson==1.11.1

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing it out. That has been removed.
#55505

sarutak added a commit that referenced this pull request Apr 24, 2026
… code

### What changes were proposed in this pull request?
This PR removes remaining PyPy related code.

### Why are the changes needed?
It's almost done in #54988 but there are still a few left and suggested to remove them
#55369 (comment)

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes #55505 from sarutak/remove-pypy.

Authored-by: Kousuke Saruta <sarutak@amazon.co.jp>
Signed-off-by: Kousuke Saruta <sarutak@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants