Skip to content

[SPARK-56512][CORE] Avoid redundant BlockId parsing in ShuffleBlockFetcherIterator #55374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LuciferYang wants to merge 1 commit into from
Closed

[SPARK-56512][CORE] Avoid redundant BlockId parsing in ShuffleBlockFetcherIterator #55374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,9 @@ final class ShuffleBlockFetcherIterator(
buf.retain()
remainingBlocks -= blockId
blockOOMRetryCounts.remove(blockId)
updateMergedReqsDuration(BlockId(blockId).isShuffleChunk)
results.put(SuccessFetchResult(BlockId(blockId), infoMap(blockId)._2,
val blkId = BlockId(blockId)
updateMergedReqsDuration(blkId.isShuffleChunk)
Copy link
Copy Markdown

@lakechd lakechd Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the implementation seems different from pr memo description

Copy link
Copy Markdown
Contributor Author

@LuciferYang LuciferYang Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look! Could you point out specifically which part of the description seems different from the implementation? I'd be happy to clarify or update.

results.put(SuccessFetchResult(blkId, infoMap(blockId)._2,
address, infoMap(blockId)._1, buf, remainingBlocks.isEmpty))
logDebug("remainingBlocks: " + remainingBlocks)
enqueueDeferredFetchRequestIfNecessary()
Expand Down