[SPARK-56643][CONNECT][TESTS] Add DSv2 temp view with stored plan tests using Spark Connect mode#55455
Closed
longvu-db wants to merge 5 commits intoapache:masterfrom
Closed
[SPARK-56643][CONNECT][TESTS] Add DSv2 temp view with stored plan tests using Spark Connect mode#55455longvu-db wants to merge 5 commits intoapache:masterfrom
longvu-db wants to merge 5 commits intoapache:masterfrom
Conversation
longvu-db
changed the title
longvu-db
changed the title
Co-authored-by: Isaac
Remove all irrelevant files (catalog helpers, DataFrameWriter changes, base traits). Add DataSourceV2TempViewConnectSuite with 11 tests matching the classic PR structure exactly. Co-authored-by: Isaac
longvu-db
force-pushed
the
dsv2-connect-pr1-temp-views
branch
from
0c52d1b to
d13fa35
Compare
longvu-db
changed the title
longvu-db
changed the title
…s in S5 Add session variants for scenarios 3 (column removal) and 4 (table recreate). Add v_unfiltered view to scenario 5. Include InMemoryBaseTable fix for column drop data migration. Add section comments for all 7 scenarios. Use separate alterTable calls for external variants. Co-authored-by: Isaac
Remove InMemoryBaseTable change, extra session tests, v_unfiltered, and section comments to match the current PR apache#55540 structure exactly. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add 11 new tests in
DataSourceV2TempViewConnectSuitethat verify temporary view behavior with stored plans when the underlying DSv2 table changes, using Spark Connect. The tests cover all 7 scenarios from the DSv2 table refresh design doc:Each test creates a DSv2 table via a Connect session, inserts initial data, builds a temp view with a filter (
salary < 999) to demonstrate stored plan behavior, and verifies the view after table modifications.External writes use the direct catalog API (
loadTable+withData) to simulate writes from outside the session.This is the Spark Connect counterpart of #55540.
Why are the changes needed?
The existing SPARK-53924 tests in
DataSourceV2DataFrameSuitecover basic schema change detection for temp views on DSv2 tables but are missing:These tests provide comprehensive coverage for the DSv2 table refresh design doc's Section 1 (Temp views with stored plans), exercised through Spark Connect.
Does this PR introduce any user-facing change?
No. This PR only adds tests.
How was this patch tested?
All 11 new tests pass:
Was this patch authored or co-authored using generative AI tooling?
Yes.