[SPARK-56586][CONNECT][TESTS] Retry flaky python foreachBatch termination test#55481
Closed
Feelitx wants to merge 3 commits into
Closed
[SPARK-56586][CONNECT][TESTS] Retry flaky python foreachBatch termination test#55481Feelitx wants to merge 3 commits into
Feelitx wants to merge 3 commits into
Conversation
HyukjinKwon
approved these changes
Apr 22, 2026
Member
|
Merged to master. |
Member
|
cc @zhengruifeng FYI |
HyukjinKwon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR un-skips the Connect parity test
test_streaming_foreach_batch_graceful_stopand applies the retry-timeout infrastructure introduced in SPARK-52843 (@eventuallyand@timeout). Additionally, it replaces the py4j-specific_jvm.java.lang.Thread.sleep()call with standard Pythontime.sleep().Why are the changes needed?
This resolves SPARK-56565. The test for
foreachBatchgraceful stop was previously skipped for Connect because it inherently relied on Py4J's pinned thread execution model and caused flaky timeout behaviors. With the new retry infrastructure, we can safely re-enable it for the Connect module.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Verified by standard GitHub Actions on personal fork.
Was this patch authored or co-authored using generative AI tooling?
No.