[SPARK-56587][SQL] Show table names for V2 write nodes in UI#55510
Closed
wangyum wants to merge 2 commits into
Closed
[SPARK-56587][SQL] Show table names for V2 write nodes in UI#55510wangyum wants to merge 2 commits into
wangyum wants to merge 2 commits into
Conversation
Pass relation names into V2 write execs and render them from V2ExistingTableWriteExec.nodeName so Append, Overwrite, dynamic overwrite, ReplaceData, and WriteDelta all display table context consistently in SQL UI.
pan3793
reviewed
Apr 24, 2026
| write: Write, | ||
| rowLevelCommand: RowLevelOperation.Command) extends RowLevelWriteExec { | ||
| rowLevelCommand: RowLevelOperation.Command, | ||
| tableName: String) extends RowLevelWriteExec { |
Member
There was a problem hiding this comment.
I wonder if we should define a method in o.a.s.sql.connector.write.Write as a contract to allow the connector to report the table name or something else they want to display as part of the node name, this way, we can display more things, i.e., ReplaceData iceberg cat.ns.t (CoW)
@aokolnychyi do you have any suggestions?
Member
There was a problem hiding this comment.
maybe a similar api is required for batch scan, for built-in file-based tables, the node name is Scan parquet cat.db.t, while format (e.g., iceberg) is missing in the batch scan node name
dongjoon-hyun
approved these changes
Apr 28, 2026
Member
|
cc @yaooqinn for SPARK-55760 Spark Web UI Modernization, too. I added this as a subtask of SPARK-55760. |
Member
|
Late LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR modifies the physical execution nodes for DataSourceV2 write operations (such as
AppendDataExec,OverwriteByExpressionExec,OverwritePartitionsDynamicExec,ReplaceDataExec, andWriteDeltaExec) to accept and store the destinationtableName. It then updates thenodeNameproperty in the baseV2ExistingTableWriteExectrait to include this table name in its output.Why are the changes needed?
To improve observability and debuggability in the Spark SQL UI and Explain plans. Previously, V2 write nodes were displayed generically (e.g.,
AppendData). With this change, the UI will explicitly show the context of the write operation (e.g.,AppendData catalog.namespace.table_name), making it much easier for users to understand which tables are being modified.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test and manual test:
Was this patch authored or co-authored using generative AI tooling?
No.