[SPARK-56607][PYTHON] Remove unnecessary __new__ and __init__#55526
Closed
gaogaotiantian wants to merge 5 commits intoapache:masterfrom
Closed
[SPARK-56607][PYTHON] Remove unnecessary __new__ and __init__#55526gaogaotiantian wants to merge 5 commits intoapache:masterfrom
gaogaotiantian wants to merge 5 commits intoapache:masterfrom
Conversation
HyukjinKwon
approved these changes
Apr 24, 2026
HyukjinKwon
reviewed
Apr 24, 2026
| @@ -99,11 +100,6 @@ def tearDownClass(cls): | |||
|
|
|||
|
|
|||
| class MockDataset(DataFrame): | |||
Member
There was a problem hiding this comment.
Hm, actually why should we change this parent dataframe to classic dataframe?
Contributor
Author
There was a problem hiding this comment.
Because it is supposed to use the classic dataframe. The "parent" dataframe is not supposed to be used directly.
# HACK ALERT!! this is to reduce the backward compatibility concern, and returns
# Spark Classic DataFrame by default. This is NOT an API, and NOT supposed to
# be directly invoked. DO NOT use this constructor.We have a really weird way to keep backward compatibility by calling child __new__ in parent class. If we do not inherit the classic dataframe, we need to write a __new__ method for MockDataset because the parent dataframe's __new__ expects certain arguments that MockDataset does not provide. Both classic and connect DataFrame is fine because they have __init__ to indicate type annotations.
Yicong-Huang
approved these changes
Apr 24, 2026
Contributor
|
merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
__init__call in__new__because it's unnecessary and could be unsound.__new__method when it just does the default thing.DataFramewhere the base class calls the derived class__new__method, but made it cleaner.Why are the changes needed?
Remove some unnecessary and potentially buggy code. Also less mypy ignores.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.
Was this patch authored or co-authored using generative AI tooling?
No.