[SPARK-55726][PYTHON][TEST][FOLLOW-UP] Write grouped benchmark data as one Arrow IPC stream per DataFrame#55527
Closed
Yicong-Huang wants to merge 3 commits into
Closed
[SPARK-55726][PYTHON][TEST][FOLLOW-UP] Write grouped benchmark data as one Arrow IPC stream per DataFrame#55527Yicong-Huang wants to merge 3 commits into
Yicong-Huang wants to merge 3 commits into
Conversation
zhengruifeng
approved these changes
Apr 24, 2026
Contributor
|
merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix
MockProtocolWriter.write_grouped_data_payloadinpython/benchmarks/bench_eval_type.pyto write each DataFrame as one Arrow IPC stream (multiple batches per stream), matching the real worker wire protocol.num_dfsis now inferred from the group tuple length. Grouped/cogrouped data factories return nested-list shapes accordingly.Why are the changes needed?
The old writer emitted one stream per RecordBatch, while declaring
num_dfs=1upfront. When a group spanned more than one batch, the worker read the next stream's bytes asnum_dfsfor the next group. Thelg_grp_few_col/lg_grp_many_colscenarios inGroupedMapPandasUDF{Time,Peakmem}Bench(100K rows/group with defaultMAX_RECORDS_PER_BATCH=10_000) hit this:Does this PR introduce any user-facing change?
No.
How was this patch tested?
Ran all 15
_GroupedMapPandasBenchMixinscenario x UDF combinations and one scenario per other grouped/cogrouped bench class locally. All pass.lg_grp_*fail on master before this patch and pass after.Was this patch authored or co-authored using generative AI tooling?
No.