Skip to content

[SPARK-56575][CORE] Extract scheduleResubmit() helper to remove identical code blocks #55614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jiangxb1987 wants to merge 1 commit into from
+13 −17
Closed

[SPARK-56575][CORE] Extract scheduleResubmit() helper to remove identical code blocks #55614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 13 additions & 17 deletions core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,16 @@ private[spark] class DAGScheduler(
private val messageScheduler =
ThreadUtils.newDaemonSingleThreadScheduledExecutor("dag-scheduler-message")

private def scheduleResubmit(): Unit = {
messageScheduler.schedule(
new Runnable {
override def run(): Unit = eventProcessLoop.post(ResubmitFailedStages)
},
DAGScheduler.RESUBMIT_TIMEOUT,
TimeUnit.MILLISECONDS
)
}

private[spark] var eventProcessLoop = new DAGSchedulerEventProcessLoop(this)
// Used for test only. Some tests uses the same thread of the event poster to
// process the events to ensure the deterministic behavior during the test.
Expand Down Expand Up @@ -2179,13 +2189,7 @@ private[spark] class DAGScheduler(
if (noResubmitEnqueued) {
logInfo(log"Resubmitting ${MDC(FAILED_STAGE, stage)} " +
log"(${MDC(FAILED_STAGE_NAME, stage.name)}) due to rollback.")
messageScheduler.schedule(
new Runnable {
override def run(): Unit = eventProcessLoop.post(ResubmitFailedStages)
},
DAGScheduler.RESUBMIT_TIMEOUT,
TimeUnit.MILLISECONDS
)
scheduleResubmit()
}
}

Expand Down Expand Up @@ -2510,13 +2514,7 @@ private[spark] class DAGScheduler(
log"Resubmitting ${MDC(STAGE, mapStage)} " +
log"(${MDC(STAGE_NAME, mapStage.name)}) and ${MDC(FAILED_STAGE, failedStage)} " +
log"(${MDC(FAILED_STAGE_NAME, failedStage.name)}) due to fetch failure")
messageScheduler.schedule(
new Runnable {
override def run(): Unit = eventProcessLoop.post(ResubmitFailedStages)
},
DAGScheduler.RESUBMIT_TIMEOUT,
TimeUnit.MILLISECONDS
)
scheduleResubmit()
}
}

Expand Down Expand Up @@ -2623,9 +2621,7 @@ private[spark] class DAGScheduler(
if (noResubmitEnqueued) {
logInfo(log"Resubmitting ${MDC(FAILED_STAGE, failedStage)} " +
log"(${MDC(FAILED_STAGE_NAME, failedStage.name)}) due to barrier stage failure.")
messageScheduler.schedule(new Runnable {
override def run(): Unit = eventProcessLoop.post(ResubmitFailedStages)
}, DAGScheduler.RESUBMIT_TIMEOUT, TimeUnit.MILLISECONDS)
scheduleResubmit()
}
}
}
Expand Down