[SPARK-56672][SQL] Rename TableViewCatalog.listRelationSummaries to listTableAndViewSummaries#55616
Closed
gengliangwang wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-56672][SQL] Rename TableViewCatalog.listRelationSummaries to listTableAndViewSummaries#55616gengliangwang wants to merge 1 commit intoapache:masterfrom
gengliangwang wants to merge 1 commit intoapache:masterfrom
Conversation
…istTableAndViewSummaries Rename the unified listing method on `TableViewCatalog` to make its scope explicit -- it returns both tables and views -- and to avoid overloading Spark's "Relation" terminology. Updates the declaration and its two existing call sites/comments.
Member
Author
|
This is a follow-up of #55593. cc @cloud-fan @viirya for review. |
HyukjinKwon
approved these changes
Apr 30, 2026
viirya
approved these changes
Apr 30, 2026
Member
Author
|
@HyukjinKwon @viirya thanks for the review. Merging to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rename the unified listing method on
TableViewCatalogfromlistRelationSummariestolistTableAndViewSummaries. Updates the declaration inTableViewCatalog.javaand the two existing references introduced by SPARK-56655:sql/catalyst/.../TableViewCatalog.java-- method declaration + javadocsql/core/.../ShowTablesExec.scala-- call site + scaladoc referencesql/core/.../DataSourceV2MetadataViewSuite.scala-- comment referenceWhy are the changes needed?
The new name explicitly states what the method returns (tables and views) and avoids overloading Spark's existing "Relation" terminology (
BaseRelation,LogicalRelation, etc.), matching the rename rationale that already changedRelationCatalog->TableViewCatalogin SPARK-56655. The API is still@Evolvingand unreleased, so this is a pre-release rename with no deprecation cycle needed.Does this PR introduce any user-facing change?
No end-user behavior change.
How was this patch tested?
Pure rename; existing tests in
DataSourceV2MetadataViewSuiteexercise the renamed method viaSHOW TABLESon aTableViewCatalog.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude (Anthropic), claude-opus-4