[SPARK-55810][UI] Fix missing spacing between table and pagination controls in Jobs and Stages page#55626
[SPARK-55810][UI] Fix missing spacing between table and pagination controls in Jobs and Stages page#55626XdithyX wants to merge 1 commit intoapache:masterfrom
Conversation
|
@dongjoon-hyun @yaooqinn Can you please take a look? Thanks! |
|
Hi @XdithyX, could you enable GA in your forked repository? |
|
|
||
| <div class="d-flex justify-content-between align-items-center"> | ||
| <div class="d-flex align-items-center"> | ||
| <div class="d-flex align-items-center mb-3"> |
There was a problem hiding this comment.
Adding mb-3 only to the left inner child breaks symmetry inside the flex container. The left child gains a 1rem bottom margin, but the right child (the Jump-to form) does not, so the two children's bottom edges no longer align under align-items-center. Also, since pageNavigation() is rendered both above and below the table, the same mb-3 gets applied to the bottom nav as well, adding unnecessary spacing there.
Suggested fix: apply the margin to the outer flex container instead:
- <div class="d-flex justify-content-between align-items-center">
- <div class="d-flex align-items-center mb-3">
+ <div class="d-flex justify-content-between align-items-center mb-3">
+ <div class="d-flex align-items-center">
<span class="pe-1">Page: </span>
<ul class="pagination mb-0">There was a problem hiding this comment.
@sarutak Thanks for pointing this out! You're right, the margin should be applied to the outer flex container to keep alignment consistent.
I’ve updated the change accordingly. The earlier version mistakenly applied mb-3 to the inner container.
Also, I have enabled github actions on my fork, CI is currently running.
Added screenshots for Jobs page as well.
Thanks!
…ntrols in Jobs and Stages page
What changes were proposed in this pull request?
This PR fixes a UI regression in the Spark Web UI (Jobs and Stages pages) where spacing between the data table and the pagination controls ("Page", "Jump to", "Show items") was missing (SPARK-55810).
The issue was introduced during the Bootstrap upgrade in #54552, which caused the pagination controls to appear visually attached to the table. This change restores appropriate spacing between these elements to improve layout clarity and consistency.
Why are the changes needed?
Without proper spacing, the table and pagination controls appear cramped and visually misaligned, which negatively impacts readability and overall user experience in the Spark Web UI.
This is a regression caused by the Bootstrap upgrade and should be fixed to maintain UI consistency.
Does this PR introduce any user-facing change?
Yes.
It improves the visual layout of the Jobs and Stages pages in the Spark Web UI by restoring proper spacing between the table and pagination controls.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.
Screenshots