[SPARK-56684][K8S] Expose KubernetesClusterSchedulerBackend.kubernetesClient to k8s package#55634
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-56684][K8S] Expose KubernetesClusterSchedulerBackend.kubernetesClient to k8s package#55634dongjoon-hyun wants to merge 1 commit into
KubernetesClusterSchedulerBackend.kubernetesClient to k8s package#55634dongjoon-hyun wants to merge 1 commit into
Conversation
…ent` to `k8s` package
KubernetesClusterSchedulerBackend.kubernetesClient to k8s packageKubernetesClusterSchedulerBackend.kubernetesClient to k8s package
Member
Author
|
Could you review this K8s API visibility PR, @huaxingao ? This is a subtask of SPARK-56603 Improve K8s Resource Manager API |
Member
Author
|
Thank you so much, @huaxingao ~ |
Member
Author
|
Merged to master for Apache Spark 4.2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR promotes the
kubernetesClientconstructor parameter ofKubernetesClusterSchedulerBackendto aprivate[k8s] val, exposing it as a read-only member to other components in theorg.apache.spark.scheduler.cluster.k8spackage.Why are the changes needed?
Like
ExecutorResizePlugin, many plugins currently build its ownKubernetesClientviaSparkKubernetesClientFactory.createKubernetesClient(...). This produces multiple clients in the driver process that target the same API server with the same credentials.The driver already owns a single
KubernetesClientthroughKubernetesClusterSchedulerBackend, whose lifecycle is managed instart()/stop(). Exposing it asprivate[k8s] vallets package-local components reuse this shared client in follow-up work, without widening the API surface to other modules or external users.This PR is intentionally limited to the visibility change. Reusing the shared client from existing plugins is left to follow-up PRs so each change stays minimal and reviewable.
Does this PR introduce any user-facing change?
No. The visibility is
private[k8s], so the change is invisible outside theorg.apache.spark.scheduler.cluster.k8spackage.How was this patch tested?
Pass the CIs with a new unit test.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7