[SPARK-56717][PYTHON][TESTS] Add ASV microbenchmark for SQL_ARROW_TABLE_UDF#55673
Open
Yicong-Huang wants to merge 2 commits intoapache:masterfrom
Open
[SPARK-56717][PYTHON][TESTS] Add ASV microbenchmark for SQL_ARROW_TABLE_UDF#55673Yicong-Huang wants to merge 2 commits intoapache:masterfrom
Yicong-Huang wants to merge 2 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add an ASV micro-benchmark for
SQL_ARROW_TABLE_UDF(Python UDTF withuseArrow=True) eval type tobench_eval_type.py.The new benchmark drives the worker through the UDTF wire protocol (separate from
SQL_*_UDF: nonum_udfs/num_chained/result_id; insteadnum_partition_child_indexes, optional pickledAnalyzeResult, the handler class, return-type JSON, and udtf name). It also threadsinput_typethroughEvalConfso the non-legacy Arrow code path is exercised.Supporting changes in
MockProtocolWriter:write_worker_inputaccepts an optionaleval_confdict alongsiderunner_conf.write_udtf_payloadfor the UDTF-specific command frame.UDTFs covered:
identity_udtf(1->1),explode_udtf(1->3),filter_udtf(1->0/1),stringify_udtf(1->1, type change). Row counts are scaled down vsSQL_ARROW_BATCHED_UDFbecause the worker callsLocalDataToArrowConversion.convertonce per input row in this path.Why are the changes needed?
Part of SPARK-55724. Establishes a performance baseline before refactoring
SQL_ARROW_TABLE_UDF.Does this PR introduce any user-facing change?
No
How was this patch tested?
COLUMNS=120 ./python/asv run --python=same --bench "ArrowTableUDF" -a "repeat=(3,5,5.0)"(one of two stable runs):ArrowTableUDFTimeBench:ArrowTableUDFPeakmemBench:Was this patch authored or co-authored using generative AI tooling?
No