[MINOR][DOCS] Clarify when to ask the user before running tests in AGENTS.md#55685
Closed
cloud-fan wants to merge 1 commit into
Closed
[MINOR][DOCS] Clarify when to ask the user before running tests in AGENTS.md#55685cloud-fan wants to merge 1 commit into
cloud-fan wants to merge 1 commit into
Conversation
dongjoon-hyun
approved these changes
May 5, 2026
HyukjinKwon
approved these changes
May 5, 2026
Contributor
Author
|
thanks for the review, merging to master/4.x/4.2 (as branch 4.2 is still active before RC cut) |
cloud-fan
added a commit
that referenced
this pull request
May 6, 2026
…ENTS.md ### What changes were proposed in this pull request? Tighten the wording in `AGENTS.md` that tells coding agents to ask the user about pending changes before running tests. The previous wording fired even when the user explicitly asked for a test run. Before: > Build and tests can take a long time. Before running tests, ask the user if they have more changes to make. After: > Build and tests can take a long time. If the user explicitly asked to run tests, run them. Otherwise (you are running tests on your own to verify a change), first ask the user if they have more changes to make. ### Why are the changes needed? The intent of the original instruction was to avoid kicking off a long, agent-initiated test run when the user has more edits coming. But as written, it also applies when the user explicitly requests a test run, which makes the prompt redundant and annoying. Spelling out both branches makes it easier for LLMs to follow the rule correctly. ### Does this PR introduce _any_ user-facing change? No. Documentation-only update for coding agent instructions. ### How was this patch tested? N/A — documentation only. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 4.7) Closes #55685 from cloud-fan/minor-agents-md-test-prompt. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit feab925) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
cloud-fan
added a commit
that referenced
this pull request
May 6, 2026
…ENTS.md ### What changes were proposed in this pull request? Tighten the wording in `AGENTS.md` that tells coding agents to ask the user about pending changes before running tests. The previous wording fired even when the user explicitly asked for a test run. Before: > Build and tests can take a long time. Before running tests, ask the user if they have more changes to make. After: > Build and tests can take a long time. If the user explicitly asked to run tests, run them. Otherwise (you are running tests on your own to verify a change), first ask the user if they have more changes to make. ### Why are the changes needed? The intent of the original instruction was to avoid kicking off a long, agent-initiated test run when the user has more edits coming. But as written, it also applies when the user explicitly requests a test run, which makes the prompt redundant and annoying. Spelling out both branches makes it easier for LLMs to follow the rule correctly. ### Does this PR introduce _any_ user-facing change? No. Documentation-only update for coding agent instructions. ### How was this patch tested? N/A — documentation only. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 4.7) Closes #55685 from cloud-fan/minor-agents-md-test-prompt. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit feab925) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Tighten the wording in
AGENTS.mdthat tells coding agents to ask the user about pending changes before running tests. The previous wording fired even when the user explicitly asked for a test run.Before:
After:
Why are the changes needed?
The intent of the original instruction was to avoid kicking off a long, agent-initiated test run when the user has more edits coming. But as written, it also applies when the user explicitly requests a test run, which makes the prompt redundant and annoying. Spelling out both branches makes it easier for LLMs to follow the rule correctly.
Does this PR introduce any user-facing change?
No. Documentation-only update for coding agent instructions.
How was this patch tested?
N/A — documentation only.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.7)