[SPARK-56731][PYTHON] Fix type annotation for DataFrame.replace#55694
Closed
gaogaotiantian wants to merge 1 commit into
Closed
[SPARK-56731][PYTHON] Fix type annotation for DataFrame.replace#55694gaogaotiantian wants to merge 1 commit into
gaogaotiantian wants to merge 1 commit into
Conversation
zhengruifeng
approved these changes
May 6, 2026
zhengruifeng
pushed a commit
that referenced
this pull request
May 6, 2026
### What changes were proposed in this pull request? Fix type annotation for `DataFrame.replace` ### Why are the changes needed? The old one is actually wrong because you can't pass `subset` as a positional argument if you skip `value`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #55694 from gaogaotiantian/df-replace-type-hint. Authored-by: Tian Gao <gaogaotiantian@hotmail.com> Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com> (cherry picked from commit 4ec0da9) Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com>
Contributor
|
merged to master and 4.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix type annotation for
DataFrame.replaceWhy are the changes needed?
The old one is actually wrong because you can't pass
subsetas a positional argument if you skipvalue.Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.
Was this patch authored or co-authored using generative AI tooling?
No.