[MINOR][PYTHON][TESTS] Rename test_utils to test_parity_utils for Connect parity convention#55695
Closed
zhengruifeng wants to merge 1 commit into
Closed
[MINOR][PYTHON][TESTS] Rename test_utils to test_parity_utils for Connect parity convention#55695zhengruifeng wants to merge 1 commit into
test_utils to test_parity_utils for Connect parity convention#55695zhengruifeng wants to merge 1 commit into
Conversation
… Connect parity convention Following up on the `test_resources` -> `test_parity_resources` rename, the Connect parity test file `python/pyspark/sql/tests/connect/test_utils.py` and its class `ConnectUtilsTests` are the only remaining ones in `python/pyspark/sql/tests/connect/` that don't follow the established naming convention used by 200+ other parity tests: - Filename should be `test_parity_<name>.py`. - Class name should be `<Name>ParityTests`. This PR renames: - `python/pyspark/sql/tests/connect/test_utils.py` -> `python/pyspark/sql/tests/connect/test_parity_utils.py` - `ConnectUtilsTests` -> `UtilsParityTests` The reference to the module path is updated in `dev/sparktestsupport/modules.py`. Generated-by: Claude Code (Opus 4.7)
HyukjinKwon
approved these changes
May 6, 2026
zhengruifeng
added a commit
that referenced
this pull request
May 6, 2026
… Connect parity convention ### What changes were proposed in this pull request? The Connect parity test file `python/pyspark/sql/tests/connect/test_utils.py` and its class `ConnectUtilsTests` don't follow the naming convention used by 200+ other parity tests in `python/pyspark/sql/tests/connect/`: - Filename should be `test_parity_<name>.py`. - Class name should be `<Name>ParityTests`. This PR renames: - `python/pyspark/sql/tests/connect/test_utils.py` -> `python/pyspark/sql/tests/connect/test_parity_utils.py` - `ConnectUtilsTests` -> `UtilsParityTests` The reference to the old module path is updated in `dev/sparktestsupport/modules.py`. ### Why are the changes needed? Consistency. The `test_parity_*` filename and `*ParityTests` class name are the established convention across the Connect parity test suite; this rename brings the utils parity test in line and makes it easier to locate and identify parity tests at a glance. ### Does this PR introduce _any_ user-facing change? No. Test-only change with no behavioral impact. ### How was this patch tested? Existing tests; only filename and class name changed. The test module is still discovered through `dev/sparktestsupport/modules.py`. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.7) Closes #55695 from zhengruifeng/rename-test-parity-utils. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com> (cherry picked from commit d23148e) Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com>
Contributor
Author
|
merged to master and 4.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The Connect parity test file
python/pyspark/sql/tests/connect/test_utils.pyand its classConnectUtilsTestsdon't follow the naming convention used by 200+ other parity tests inpython/pyspark/sql/tests/connect/:test_parity_<name>.py.<Name>ParityTests.This PR renames:
python/pyspark/sql/tests/connect/test_utils.py->python/pyspark/sql/tests/connect/test_parity_utils.pyConnectUtilsTests->UtilsParityTestsThe reference to the old module path is updated in
dev/sparktestsupport/modules.py.Why are the changes needed?
Consistency. The
test_parity_*filename and*ParityTestsclass name are the established convention across the Connect parity test suite; this rename brings the utils parity test in line and makes it easier to locate and identify parity tests at a glance.Does this PR introduce any user-facing change?
No. Test-only change with no behavioral impact.
How was this patch tested?
Existing tests; only filename and class name changed. The test module is still discovered through
dev/sparktestsupport/modules.py.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)