[SPARK-56736][K8S] Add sparkVersion method to KubernetesConf abstract class#55697
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-56736][K8S] Add sparkVersion method to KubernetesConf abstract class#55697dongjoon-hyun wants to merge 1 commit into
sparkVersion method to KubernetesConf abstract class#55697dongjoon-hyun wants to merge 1 commit into
Conversation
dongjoon-hyun
changed the title
sparkVersion method to KubernetesConf abstract classsparkVersion method to KubernetesConf abstract class
Member
Author
|
Could you review this PR, @yaooqinn ? |
Member
Author
|
While auditing SPARK-56603 Improve K8s Resource Manager API, I found that this is required to be complete. I hope we can land this to |
yaooqinn
approved these changes
May 6, 2026
HyukjinKwon
approved these changes
May 6, 2026
Member
Author
|
Thank you, @yaooqinn and @HyukjinKwon . |
dongjoon-hyun
added a commit
that referenced
this pull request
May 6, 2026
…ract class ### What changes were proposed in this pull request? This PR adds a `sparkVersion: String` method on `KubernetesConf` and uses it in `KubernetesDriverConf.labels` and `KubernetesExecutorConf.labels` instead of referencing the `SPARK_VERSION` constant directly. ### Why are the changes needed? Exposing the version through an overridable method gives subclasses (e.g., the Spark K8s operator) a single extension point to customize the `SPARK_VERSION_LABEL` value. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs with the newly added test cases. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.7) Closes #55697 from dongjoon-hyun/SPARK-56736. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 2e59054) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
May 6, 2026
…ract class ### What changes were proposed in this pull request? This PR adds a `sparkVersion: String` method on `KubernetesConf` and uses it in `KubernetesDriverConf.labels` and `KubernetesExecutorConf.labels` instead of referencing the `SPARK_VERSION` constant directly. ### Why are the changes needed? Exposing the version through an overridable method gives subclasses (e.g., the Spark K8s operator) a single extension point to customize the `SPARK_VERSION_LABEL` value. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs with the newly added test cases. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.7) Closes #55697 from dongjoon-hyun/SPARK-56736. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 2e59054) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a
sparkVersion: Stringmethod onKubernetesConfand uses it inKubernetesDriverConf.labelsandKubernetesExecutorConf.labelsinstead of referencing theSPARK_VERSIONconstant directly.Why are the changes needed?
Exposing the version through an overridable method gives subclasses (e.g., the Spark K8s operator) a single extension point to customize the
SPARK_VERSION_LABELvalue.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs with the newly added test cases.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)