Skip to content

[SPARK-56740][BUILD] Change version in development branch to 5.0.0#55703

Closed
HyukjinKwon wants to merge 1 commit into
apache:masterfrom
HyukjinKwon:SPARK-56740
Closed

[SPARK-56740][BUILD] Change version in development branch to 5.0.0#55703
HyukjinKwon wants to merge 1 commit into
apache:masterfrom
HyukjinKwon:SPARK-56740

Conversation

@HyukjinKwon
Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Change version in development branch to 5.0.0

Why are the changes needed?

To prepare 5.0.0 from master branch.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI in this PR should test it out.

Was this patch authored or co-authored using generative AI tooling?

No.

@zhengruifeng
Copy link
Copy Markdown
Contributor

shall we also change the version in branch-4.x to 4.x?

Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you so much, @HyukjinKwon !

@dongjoon-hyun
Copy link
Copy Markdown
Member

dongjoon-hyun commented May 6, 2026

Merged to master because currently 4.2.0-SNAPSHOT artifacts are corrupted like the following.

  • master branch published 4.2.0-SNAPSHOT
  • branch-4.x branch published 4.2.0-SNAPSHOT.
  • branch-4.2 branch published 4.2.0-SNAPSHOT. (This is correct)

Only branch-4.2 branch is supposed to publish 4.2.0-SNAPSHOT.

@dongjoon-hyun
Copy link
Copy Markdown
Member

cc @peter-toth , too.

object MimaExcludes {

// Exclude rules for 5.0.x from 4.2.0 (add 5.0-specific filters below as needed).
lazy val v50excludes: Seq[Problem => Boolean] = v42excludes
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to keep v42excludes here? Shouldn't this check be done in branch-4.x instead?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah actually yes.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove..

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually let's just keep it to reduce the diff so the Prs from master branches can be cherry-picked down to other branches and reduce the diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants