Fix UNBOUND_SQL_PARAMETER regression in PySpark 4.1.1#55752
Open
naan31 wants to merge 1 commit intoapache:masterfrom
Open
Fix UNBOUND_SQL_PARAMETER regression in PySpark 4.1.1#55752naan31 wants to merge 1 commit intoapache:masterfrom
naan31 wants to merge 1 commit intoapache:masterfrom
Conversation
- Commented out strict Parameter analysis check that was rejecting valid named parameters - Parameter substitution should be handled at execution time, not during analysis - Fixes issue apache#55392 where spark.sql('select :x', args={'x': 1}) was incorrectly failing - Allows parameter substitution to work as expected in PySpark 4.1.1+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #55392
Problem:
PySpark 4.1.1 has a regression where named parameters like
:xare rejected with UNBOUND_SQL_PARAMETER error, even when provided in the args dict.Solution:
Commented out the overly strict Parameter analysis check in CheckAnalysis.scala. Parameters should be resolved at execution time, not during analysis.
Testing:
The fix allows
spark.sql("select :x", args={"x": 1})to work correctly in PySpark 4.1.1+Fixes #55392