[SPARK-56859][SQL] Create user error for IllegalArgumentException in CSVOptions#55877
Closed
shivadarshan-devadiga wants to merge 5 commits into
Closed
[SPARK-56859][SQL] Create user error for IllegalArgumentException in CSVOptions#55877shivadarshan-devadiga wants to merge 5 commits into
shivadarshan-devadiga wants to merge 5 commits into
Conversation
HyukjinKwon
approved these changes
May 14, 2026
shivadarshan-devadiga
force-pushed
the
cveoptions-user-error
branch
from
2e9499a to
3625089
Compare
Contributor
Author
|
@HyukjinKwon The CI pipeline is green now, have made few changes to the test cases; Can you please review it and merge. Thank you |
Contributor
Author
|
Gentle ping @HyukjinKwon |
Member
|
sorry I saw it now. merging |
Member
|
Merged to master and branch-4.x. |
HyukjinKwon
pushed a commit
that referenced
this pull request
May 20, 2026
…CSVOptions ### What changes were proposed in this pull request? This PR converts IllegalArgumentException thrown by require() statements in CSVOptions to proper user-facing Spark errors with error classes ### Why are the changes needed? Currently, CSVOptions uses Scala's require() which throws generic IllegalArgumentException with plain text messages. This change aligns lineSep validation with Spark's error handling standards, making errors more actionable and consistent. ### Does this PR introduce _any_ user-facing change? Yes. The error messages for invalid lineSep values will change ### How was this patch tested? All SQL related tests were run including the linsep tests ### Was this patch authored or co-authored using generative AI tooling? No cc: markj-db MaxGekk HyukjinKwon Closes #55877 from shivadarshan-devadiga/cveoptions-user-error. Authored-by: Shivadarshan Devadiga <shivadarshan2212@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit e3c519e) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Contributor
Author
|
Thank you @HyukjinKwon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR converts IllegalArgumentException thrown by require() statements in CSVOptions to proper user-facing Spark errors with error classes
Why are the changes needed?
Currently, CSVOptions uses Scala's require() which throws generic IllegalArgumentException with plain text messages. This change aligns lineSep validation with Spark's error handling standards, making errors more actionable and consistent.
Does this PR introduce any user-facing change?
Yes. The error messages for invalid lineSep values will change
How was this patch tested?
All SQL related tests were run including the linsep tests
Was this patch authored or co-authored using generative AI tooling?
No
cc: @markj-db @MaxGekk @HyukjinKwon