[SPARK-56879][CORE][TESTS] Improve JavaUtilsSuite to be more robust#55907
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-56879][CORE][TESTS] Improve JavaUtilsSuite to be more robust#55907dongjoon-hyun wants to merge 1 commit into
JavaUtilsSuite to be more robust#55907dongjoon-hyun wants to merge 1 commit into
Conversation
dongjoon-hyun
force-pushed
the
SPARK-56879
branch
from
407f857 to
6bbef58
Compare
dongjoon-hyun
changed the title
JavaUtilsSuite to be robustJavaUtilsSuite to be more robust
peter-toth
approved these changes
May 15, 2026
Member
Author
|
Thank you, @peter-toth . |
dongjoon-hyun
added a commit
that referenced
this pull request
May 15, 2026
### What changes were proposed in this pull request? Make `JavaUtilsSuite.testCreateDirectory` scenario 4 skip the `IOException` assertion when running as `root`. ### Why are the changes needed? `root` bypasses filesystem permission checks, so `setWritable(false)` does not prevent directory creation and the test fails under root (e.g., Docker-based CI). ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.7 (1M context) Closes #55907 from dongjoon-hyun/SPARK-56879. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 87ed418) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
May 15, 2026
### What changes were proposed in this pull request? Make `JavaUtilsSuite.testCreateDirectory` scenario 4 skip the `IOException` assertion when running as `root`. ### Why are the changes needed? `root` bypasses filesystem permission checks, so `setWritable(false)` does not prevent directory creation and the test fails under root (e.g., Docker-based CI). ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.7 (1M context) Closes #55907 from dongjoon-hyun/SPARK-56879. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 87ed418) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
|
Merged to master/4.x/4.2 for Apache Spark 4.2.0 testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make
JavaUtilsSuite.testCreateDirectoryscenario 4 skip theIOExceptionassertion when running asroot.Why are the changes needed?
rootbypasses filesystem permission checks, sosetWritable(false)does not prevent directory creation and the test fails under root (e.g., Docker-based CI).Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7 (1M context)