[SPARK-56881][CORE][TESTS] Improve FsHistoryProviderSuite to be more robust#55908
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-56881][CORE][TESTS] Improve FsHistoryProviderSuite to be more robust#55908dongjoon-hyun wants to merge 1 commit into
FsHistoryProviderSuite to be more robust#55908dongjoon-hyun wants to merge 1 commit into
Conversation
peter-toth
approved these changes
May 15, 2026
Member
Author
|
Thank you, @peter-toth . |
dongjoon-hyun
added a commit
that referenced
this pull request
May 15, 2026
…e robust ### What changes were proposed in this pull request? Skip the `SPARK-3697: ignore files that cannot be read.` test when the file remains readable after `setReadable(false, false)` (i.e. running as `root`). ```scala logFile2.setReadable(false, false) assume(!logFile2.canRead, "Test requires the file to be unreadable; " + "skipping when running as root.") ``` ### Why are the changes needed? `root` bypasses POSIX permission checks, so the test's precondition (unreadable file) does not hold and the assertions fail. This mirrors the existing `assume(!Utils.isWindows)` skip on the line above. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.7) Closes #55908 from dongjoon-hyun/SPARK-56881. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit feba6f9) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
May 15, 2026
…e robust ### What changes were proposed in this pull request? Skip the `SPARK-3697: ignore files that cannot be read.` test when the file remains readable after `setReadable(false, false)` (i.e. running as `root`). ```scala logFile2.setReadable(false, false) assume(!logFile2.canRead, "Test requires the file to be unreadable; " + "skipping when running as root.") ``` ### Why are the changes needed? `root` bypasses POSIX permission checks, so the test's precondition (unreadable file) does not hold and the assertions fail. This mirrors the existing `assume(!Utils.isWindows)` skip on the line above. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.7) Closes #55908 from dongjoon-hyun/SPARK-56881. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit feba6f9) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
|
Merged to master/4.x/4.2 for Apache Spark 4.2+ testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Skip the
SPARK-3697: ignore files that cannot be read.test when the file remains readable aftersetReadable(false, false)(i.e. running asroot).Why are the changes needed?
rootbypasses POSIX permission checks, so the test's precondition (unreadable file) does not hold and the assertions fail. This mirrors the existingassume(!Utils.isWindows)skip on the line above.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)