[SPARK-56885][CORE][TESTS] Make CompressionCodecSuite be independent from the default value of io compression codec#55909
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
Conversation
…fault value of io compression codec
Member
Author
|
CI is running here. |
peter-toth
approved these changes
May 16, 2026
Contributor
|
Thank you @dongjoon-hyun , merged to |
dongjoon-hyun
added a commit
that referenced
this pull request
May 16, 2026
…t from the default value of io compression codec ### What changes were proposed in this pull request? This PR makes the `default compression codec` test in `CompressionCodecSuite` derive the expected codec class from `IO_COMPRESSION_CODEC.defaultValueString` instead of hard-coding `classOf[LZ4CompressionCodec]`. ### Why are the changes needed? To keep the test aligned with the actual default of `spark.io.compression.codec` so it survives any future default change without modification. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.7 Closes #55909 from dongjoon-hyun/SPARK-56885. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Peter Toth <peter.toth@gmail.com> (cherry picked from commit b5777c4) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
|
Thank you so much, @peter-toth . Since this is a test-only change, I cherry-picked this to branch-4.x and branch-4.2 too. |
dongjoon-hyun
added a commit
that referenced
this pull request
May 16, 2026
…t from the default value of io compression codec ### What changes were proposed in this pull request? This PR makes the `default compression codec` test in `CompressionCodecSuite` derive the expected codec class from `IO_COMPRESSION_CODEC.defaultValueString` instead of hard-coding `classOf[LZ4CompressionCodec]`. ### Why are the changes needed? To keep the test aligned with the actual default of `spark.io.compression.codec` so it survives any future default change without modification. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.7 Closes #55909 from dongjoon-hyun/SPARK-56885. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Peter Toth <peter.toth@gmail.com> (cherry picked from commit b5777c4) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 52b9422) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Contributor
Yeah, makes sense, thank you @dongjoon-hyun. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes the
default compression codectest inCompressionCodecSuitederive the expected codec class fromIO_COMPRESSION_CODEC.defaultValueStringinstead of hard-codingclassOf[LZ4CompressionCodec].Why are the changes needed?
To keep the test aligned with the actual default of
spark.io.compression.codecso it survives any future default change without modification.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7