[SPARK-53225][SQL] Upgrade datasketches-java to 7.0.1 and datasketches-memory to 4.1.0#55943
Closed
yadavay-amzn wants to merge 1 commit into
Closed
[SPARK-53225][SQL] Upgrade datasketches-java to 7.0.1 and datasketches-memory to 4.1.0#55943yadavay-amzn wants to merge 1 commit into
yadavay-amzn wants to merge 1 commit into
Conversation
…s-memory to 4.1.0 This upgrades datasketches-java from 6.2.0 to 7.0.1 and pins datasketches-memory at 4.1.0. Changes: - Update datasketches.version property from 6.2.0 to 7.0.1 - Add explicit datasketches-memory 4.1.0 dependency in dependencyManagement - Replace MemoryBoundsException (removed in memory 4.x) with IllegalArgumentException - Add jdk.incubator.foreign to test JVM modules (required by memory 4.1.0) - Remove SPARK-53327 Java 25 workaround (incompatible with memory 4.1.0 API) Closes #SPARK-53225
Contributor
Author
|
Closing -- @dongjoon-hyun had a prior PR (#51951) for this that was closed due to Java 17/21 distribution complexity. Deferring to his work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrades datasketches-java from 6.2.0 to 7.0.1 and adds explicit datasketches-memory 4.1.0 dependency.
Key changes:
pom.xml: version bumps + explicit memory dependencyThetaSketchUtils.scala/TupleSketchUtils.scala: replaced removedMemoryBoundsExceptionwithIllegalArgumentExceptionResourceImpl.java(SPARK-53327 workaround, incompatible with memory 4.1.0)make-distribution.sh,build_api_docs.rb,checkstyle-suppressions.xmlWhy are the changes needed?
Part of Spark 4.3 release work (SPARK-56754). The new version includes bug fixes and performance improvements. Also removes the SPARK-53327 workaround which is no longer needed.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
All catalyst tests pass (8926 tests), including DatasketchesHllSketchSuite, ThetasketchesAggSuite, ThetaSketchUtilsSuite, TupleSketchUtilsSuite.
Was this patch authored or co-authored using generative AI tooling?
Yes.