[SPARK-56948][SQL][TESTS] Make TPCDSQueryBenchmark heap/broadcast configurable#55988
Closed
yaooqinn wants to merge 1 commit into
Closed
[SPARK-56948][SQL][TESTS] Make TPCDSQueryBenchmark heap/broadcast configurable#55988yaooqinn wants to merge 1 commit into
yaooqinn wants to merge 1 commit into
Conversation
…figurable Switch hardcoded .set(...) to .setIfMissing(...) for spark.driver.memory, spark.executor.memory, and spark.sql.autoBroadcastJoinThreshold so they can be overridden via -Dspark.* without recompiling. Also unify spark.sql.shuffle.partitions to use setIfMissing for consistency. Defaults unchanged.
dongjoon-hyun
approved these changes
May 19, 2026
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @yaooqinn .
cc @peter-toth .
peter-toth
approved these changes
May 19, 2026
Member
Author
|
Merged to master, thank you @dongjoon-hyun @peter-toth |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Switch hardcoded
.set(...)to.setIfMissing(...)for three SparkConfkeys in
TPCDSQueryBenchmark:spark.driver.memoryspark.executor.memoryspark.sql.autoBroadcastJoinThresholdAlso unify
spark.sql.shuffle.partitionsto usesetIfMissingforconsistency (functionally equivalent to the existing
System.getPropertyform).Why are the changes needed?
.set(...)overrides any-Dspark.*JVM property, so users can'ttune heap/broadcast threshold without editing source. At SF10 / SF100
the hardcoded 3g heap OOMs.
spark.sql.shuffle.partitionsalreadysupported override in the same file — this extends the same pattern
to the remaining three keys.
Does this PR introduce any user-facing change?
No. Defaults unchanged.
How was this patch tested?
Verified locally that
-Dspark.driver.memory=72g(etc.) flow throughto the SparkConf when launched via:
Without these flags, defaults remain
3g / 3g / 20MB / 4.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7