Skip to content

[SPARK-56955][CORE] Add --sun-misc-unsafe-memory-access=allow for JDK 25+ #55999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yadavay-amzn wants to merge 1 commit into from
+13 −1
Closed

[SPARK-56955][CORE] Add --sun-misc-unsafe-memory-access=allow for JDK 25+ #55999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion launcher/src/main/java/org/apache/spark/launcher/JavaModuleOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,29 @@ public class JavaModuleOptions {
"-Dio.netty.noUnsafe=false",
"--enable-native-access=ALL-UNNAMED"};

// JDK 25+ restricts unsafe memory access by default, breaking Arrow/Netty.
private static final String[] JDK25_OPTIONS = {
"--sun-misc-unsafe-memory-access=allow"
};

/**
* Returns the default JVM runtime options used by Spark.
*/
public static String defaultModuleOptions() {
return String.join(" ", DEFAULT_MODULE_OPTIONS);
return String.join(" ", defaultModuleOptionArray());
}

/**
* Returns the default JVM runtime option array used by Spark.
*/
public static String[] defaultModuleOptionArray() {
if (Runtime.version().feature() >= 25) {
String[] combined = new String[DEFAULT_MODULE_OPTIONS.length + JDK25_OPTIONS.length];
System.arraycopy(DEFAULT_MODULE_OPTIONS, 0, combined, 0, DEFAULT_MODULE_OPTIONS.length);
System.arraycopy(JDK25_OPTIONS, 0, combined, DEFAULT_MODULE_OPTIONS.length,
JDK25_OPTIONS.length);
return combined;
}
return DEFAULT_MODULE_OPTIONS;
}
}