[SPARK-57117][BUILD] Upgrade zstd-jni to 1.5.7-9#56163
Closed
dongjoon-hyun wants to merge 4 commits into
Closed
Conversation
Member
Author
|
Could you review this PR, @LuciferYang ? |
Member
Author
|
All tests passed. |
LuciferYang
approved these changes
May 28, 2026
Contributor
LuciferYang
left a comment
LuciferYang
left a comment
There was a problem hiding this comment.
should we update the benchmark results?
Member
Author
|
Thank you, @LuciferYang . Let me regenerate them. |
peter-toth
reviewed
May 28, 2026
| Compression 10000 times at level 1 with buffer pool 593 594 1 0.0 59304.9 1.1X | ||
| Compression 10000 times at level 2 with buffer pool 626 627 1 0.0 62575.0 1.0X | ||
| Compression 10000 times at level 3 with buffer pool 730 730 0 0.0 72959.7 0.9X | ||
| Compression 10000 times at level 1 without buffer pool 1707 1708 2 0.0 170666.5 1.0X |
Contributor
There was a problem hiding this comment.
I wonder why are these jdk21 results much worse than before?
Member
Author
There was a problem hiding this comment.
Hi, @peter-toth . Since the underlying machine is changed randomly in GitHub Actions (AMD EPYC 7763 64-Core Processor vs Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz), we usually check Relative columns first. If there is no significant change relatively, it's okay. Technically, it's not completely isolated environment in the performance wise.
Member
Author
|
Merged to master for Apache Spark 5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade
zstd-jnito1.5.7-9for Apache Spark 5.Why are the changes needed?
To bring the latest bug fixes and improvements from upstream
zstd-jniv1.5.7-9.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7 (1M context)