[SPARK-57193][SQL] Refactor some helpers out of TimeWindowResolution#56246
Closed
vladimirg-db wants to merge 1 commit into
Closed
Conversation
Contributor
|
LGTM, merging to master and 4.x |
dtenedor
approved these changes
Jun 1, 2026
dtenedor
pushed a commit
that referenced
this pull request
Jun 1, 2026
### What changes were proposed in this pull request? Refactor some helpers out of `TimeWindowResolution`. ### Why are the changes needed? To reuse in the single-pass Analyzer. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? Claude. Closes #56246 from vladimirg-db/vladimir-golubev_data/time-window-resolution-reusable-helpers. Authored-by: Vladimir Golubev <vladimir.golubev@databricks.com> Signed-off-by: Daniel Tenedorio <daniel.tenedorio@databricks.com> (cherry picked from commit 90d0902) Signed-off-by: Daniel Tenedorio <daniel.tenedorio@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor some helpers out of
TimeWindowResolution.Why are the changes needed?
To reuse in the single-pass Analyzer.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
Claude.