[SPARK-55617][SQL][FOLLOWUP] Correct VariantGet @since to 4.3.0 and expand its class doc#56537
Closed
gengliangwang wants to merge 1 commit into
Closed
[SPARK-55617][SQL][FOLLOWUP] Correct VariantGet @since to 4.3.0 and expand its class doc#56537gengliangwang wants to merge 1 commit into
@since to 4.3.0 and expand its class doc#56537gengliangwang wants to merge 1 commit into
Conversation
…xpand its class doc Addresses a review comment on apache#54394: VariantGet was marked `@since 4.1.0`, but the API ships in 4.3.0 (branch-4.x, and master 5.0.0). Update `@since` to 4.3.0 and expand the minimal class Javadoc to describe the expression (the connector-facing form of variant_get / try_variant_get, produced by V2ExpressionBuilder for DSv2 pushdown). Co-authored-by: Isaac
Member
Author
|
cc @qlong |
pan3793
approved these changes
Jun 16, 2026
pan3793
changed the title
@since to 4.3.0 and expand its class doc
LuciferYang
approved these changes
Jun 16, 2026
qlong
approved these changes
Jun 16, 2026
qlong
left a comment
qlong
left a comment
Contributor
There was a problem hiding this comment.
@gengliangwang My mistake, thanks for fix it.
Member
|
BTW, please update JIRA information too. 
|
Contributor
|
@dongjoon-hyun @gengliangwang fixed the version in jira 
|
Member
Author
|
Thanks all for the review. Merging to master/4.x |
gengliangwang
added a commit
that referenced
this pull request
Jun 16, 2026
… expand its class doc ### What changes were proposed in this pull request? Follow-up to #54394 (SPARK-55617). Two documentation-only changes to the DSv2 connector expression `VariantGet`: - Correct the `since` tag from `4.1.0` to `4.3.0`. - Expand the class Javadoc (previously just "Variant get expression.") to describe what the expression represents. ### Why are the changes needed? This addresses a [review comment](#54394 (comment)) on the original PR: `VariantGet` was marked `since 4.1.0`, which does not match where the API actually ships. The change lands on master (5.0.0) and is backported to branch-4.x, so the API first appears in 4.3.0; the `since` tag should reflect that. The original one-line class doc also did not explain what the expression is or how it maps to `variant_get` / `try_variant_get`. > Note: `VariantExtraction` and `SupportsPushDownVariantExtractions` (added under SPARK-54656) carry the same `since 4.1.0` and likely need an analogous follow-up under that ticket. They are intentionally left out of this PR to keep it scoped to SPARK-55617. ### Does this PR introduce _any_ user-facing change? No behavior change. This only updates Javadoc and the `since` tag so the published API documentation is accurate. ### How was this patch tested? Documentation-only change (Javadoc and `since`); there is no code change, so no tests were added. Verified the new comment lines stay within the Java checkstyle line-length limit. ### Was this patch authored or co-authored using generative AI tooling? Yes, generated with the assistance of Claude Code (Anthropic). This pull request and its description were written by Isaac. Closes #56537 from gengliangwang/SPARK-55617-followup. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org> (cherry picked from commit 8c6f26b) Signed-off-by: Gengliang Wang <gengliang@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow-up to #54394 (SPARK-55617). Two documentation-only changes to the DSv2 connector expression
VariantGet:@sincetag from4.1.0to4.3.0.Why are the changes needed?
This addresses a review comment on the original PR:
VariantGetwas marked@since 4.1.0, which does not match where the API actually ships. The change lands on master (5.0.0) and is backported to branch-4.x, so the API first appears in 4.3.0; the@sincetag should reflect that. The original one-line class doc also did not explain what the expression is or how it maps tovariant_get/try_variant_get.Does this PR introduce any user-facing change?
No behavior change. This only updates Javadoc and the
@sincetag so the published API documentation is accurate.How was this patch tested?
Documentation-only change (Javadoc and
@since); there is no code change, so no tests were added. Verified the new comment lines stay within the Java checkstyle line-length limit.Was this patch authored or co-authored using generative AI tooling?
Yes, generated with the assistance of Claude Code (Anthropic).
This pull request and its description were written by Isaac.