[MLLIB] Add reservoir sample for feature in RandomForest and fix other issues in tree #5752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aihex
commented
Apr 28, 2015
aihex
commented
- Reservoir sample for feature
- Verify input rdd size > 0 when building DecisionTreeMetadata
- Fix other formatting issues
…r issues in tree 1. Reservoir sample for feature 2. Verify input rdd size > 0 3. Fix other formatting issues
|
Can one of the admins verify this patch? |
Member
|
Hey @AIHE this generally isn't how to propose changes. You're trying to intro a new feature and several changes that aren't quite related. Do you mind closing this PR and then review https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark ? |
Author
|
@srowen Sorry for this mixed RP. After reading the wiki, I guess I commit "Before proceeding, contributors should evaluate if the proposed change is likely to be relevant, new and actionable." I'll follow the wiki in feature's RP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.