Skip to content

Conversation

@vanzin
Copy link
Contributor

@vanzin vanzin commented Apr 30, 2015

No description provided.

@sryza
Copy link
Contributor

sryza commented Apr 30, 2015

LGTM. Did you try this out on a cluster?

@vanzin
Copy link
Contributor Author

vanzin commented Apr 30, 2015

yes I did.

Submit:

$ spark-submit --conf "spark.yarn.am.extraLibraryPath=/foo" --master yarn-client...

AM:

# ps axwww | grep Executor
17935 ?        Ss     0:00 /bin/bash -c LD_LIBRARY_PATH=/foo:...

@SparkQA
Copy link

SparkQA commented Apr 30, 2015

Test build #31440 has finished for PR 5813 at commit 1cb6f42.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • "public class " + className + extendsText + " implements java.io.Serializable
  • This patch does not change any dependencies.

@srowen
Copy link
Member

srowen commented Apr 30, 2015

LGTM

@tgravescs
Copy link
Contributor

I'm not at all against this, just pointing out we had a discussion on this before: #3409

What is the exact use case here for this that has caused this change in thinking?

@vanzin
Copy link
Contributor Author

vanzin commented May 1, 2015

Depending on your Hadoop config, if you don't have the Hadoop native libraries in the AM's lib path, you get this (sorry the first few lines of the stack trace are missing from our bug report):

at org.apache.hadoop.security.Groups.getUserToGroupsMappingService(Groups.java:280)
at org.apache.hadoop.security.UserGroupInformation.initialize(UserGroupInformation.java:269)
at org.apache.hadoop.security.UserGroupInformation.setConfiguration(UserGroupInformation.java:297)
at org.apache.spark.deploy.SparkHadoopUtil.<init>(SparkHadoopUtil.scala:43)
...

@vanzin
Copy link
Contributor Author

vanzin commented May 1, 2015

If curious, the JNI-based group mapper is org.apache.hadoop.security.JniBasedUnixGroupsMapping.

@srowen
Copy link
Member

srowen commented May 1, 2015

@tgravescs are you OK with that? Seems like you agree with the change.

@tgravescs
Copy link
Contributor

yes looks good.

@asfgit asfgit closed this in 7b5dd3e May 1, 2015
@vanzin vanzin deleted the SPARK-7281 branch May 1, 2015 23:41
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
Author: Marcelo Vanzin <vanzin@cloudera.com>

Closes apache#5813 from vanzin/SPARK-7281 and squashes the following commits:

1cb6f42 [Marcelo Vanzin] [SPARK-7281] [yarn] Add option to set AM's lib path in client mode.
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
Author: Marcelo Vanzin <vanzin@cloudera.com>

Closes apache#5813 from vanzin/SPARK-7281 and squashes the following commits:

1cb6f42 [Marcelo Vanzin] [SPARK-7281] [yarn] Add option to set AM's lib path in client mode.
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
Author: Marcelo Vanzin <vanzin@cloudera.com>

Closes apache#5813 from vanzin/SPARK-7281 and squashes the following commits:

1cb6f42 [Marcelo Vanzin] [SPARK-7281] [yarn] Add option to set AM's lib path in client mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants