Skip to content

Conversation

@kayousterhout
Copy link
Contributor

cc @pwendell @sarutak

This commit cleans up some unnecessary code, eliminates the feature where when you mouse-over a box in the timeline, the corresponding task is highlighted in the table (because that feature is only useful in the rare case when you have a very small number of tasks, in which case it's easy to figure out the mapping anyway), and fixes a bug where nothing shows up if you try to visualize a stage with only 1 task.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 15, 2015

Test build #32857 has started for PR 6202 at commit dfd29d4.

@sarutak
Copy link
Member

sarutak commented May 15, 2015

Thanks for the bug fix and cleanup @kayousterhout !
I inspected the change and checked the appearance. In terms of removing the highlighting, I agree with you and how about adding a feature in order to jump to the corresponding row instead?
@pwendell , what do you think about the removal because you suggested this highlighting feature.

Once the highlighting thing is resolved, LGTM.

@pwendell
Copy link
Contributor

I think @kayousterhout is right - we can remove the feature since it's only
useful in a small number of cases.

On Fri, May 15, 2015 at 3:54 PM, Kousuke Saruta notifications@github.com
wrote:

Thanks for the bug fix and cleanup @kayousterhout
https://github.com/kayousterhout !
I inspected the change and checked the appearance. In terms of removing
the highlighting, I agree with you and how about adding a feature in order
to jump to the corresponding row instead?
@pwendell https://github.com/pwendell , what do you think about the
removal because you suggested this highlighting feature.

Once the highlighting thing is resolved, LGTM.


Reply to this email directly or view it on GitHub
#6202 (comment).

@SparkQA
Copy link

SparkQA commented May 15, 2015

Test build #32857 has finished for PR 6202 at commit dfd29d4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32857/
Test PASSed.

@kayousterhout
Copy link
Contributor Author

@sarutak Let's do that as a separate PR (the feature so you can click on a link to jump to the correct row), just so we can get this cleanup in!

asfgit pushed a commit that referenced this pull request May 16, 2015
cc pwendell sarutak

This commit cleans up some unnecessary code, eliminates the feature where when you mouse-over a box in the timeline, the corresponding task is highlighted in the table (because that feature is only useful in the rare case when you have a very small number of tasks, in which case it's easy to figure out the mapping anyway), and fixes a bug where nothing shows up if you try to visualize a stage with only 1 task.

Author: Kay Ousterhout <kayousterhout@gmail.com>

Closes #6202 from kayousterhout/SPARK-7676 and squashes the following commits:

dfd29d4 [Kay Ousterhout] [SPARK-7676] Bug fix and cleanup of stage timeline view

(cherry picked from commit e745456)
Signed-off-by: Kay Ousterhout <kayousterhout@gmail.com>
@asfgit asfgit closed this in e745456 May 16, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
cc pwendell sarutak

This commit cleans up some unnecessary code, eliminates the feature where when you mouse-over a box in the timeline, the corresponding task is highlighted in the table (because that feature is only useful in the rare case when you have a very small number of tasks, in which case it's easy to figure out the mapping anyway), and fixes a bug where nothing shows up if you try to visualize a stage with only 1 task.

Author: Kay Ousterhout <kayousterhout@gmail.com>

Closes apache#6202 from kayousterhout/SPARK-7676 and squashes the following commits:

dfd29d4 [Kay Ousterhout] [SPARK-7676] Bug fix and cleanup of stage timeline view
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
cc pwendell sarutak

This commit cleans up some unnecessary code, eliminates the feature where when you mouse-over a box in the timeline, the corresponding task is highlighted in the table (because that feature is only useful in the rare case when you have a very small number of tasks, in which case it's easy to figure out the mapping anyway), and fixes a bug where nothing shows up if you try to visualize a stage with only 1 task.

Author: Kay Ousterhout <kayousterhout@gmail.com>

Closes apache#6202 from kayousterhout/SPARK-7676 and squashes the following commits:

dfd29d4 [Kay Ousterhout] [SPARK-7676] Bug fix and cleanup of stage timeline view
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
cc pwendell sarutak

This commit cleans up some unnecessary code, eliminates the feature where when you mouse-over a box in the timeline, the corresponding task is highlighted in the table (because that feature is only useful in the rare case when you have a very small number of tasks, in which case it's easy to figure out the mapping anyway), and fixes a bug where nothing shows up if you try to visualize a stage with only 1 task.

Author: Kay Ousterhout <kayousterhout@gmail.com>

Closes apache#6202 from kayousterhout/SPARK-7676 and squashes the following commits:

dfd29d4 [Kay Ousterhout] [SPARK-7676] Bug fix and cleanup of stage timeline view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants