Skip to content

[SPARK-7605] [MLlib] [PySpark] Python API for ElementwiseProduct #6346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MechCoder wants to merge 2 commits into from
Closed

[SPARK-7605] [MLlib] [PySpark] Python API for ElementwiseProduct #6346

MechCoder wants to merge 2 commits into from

Conversation

@MechCoder
Copy link
Contributor

@MechCoder MechCoder commented May 22, 2015

Python API for org.apache.spark.mllib.feature.ElementwiseProduct

@MechCoder
Copy link
Contributor Author

MechCoder commented May 22, 2015

ping @mengxr @jkbradley

@SparkQA
Copy link

SparkQA commented May 22, 2015

Test build #33331 has finished for PR 6346 at commit 5f81d81.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ElementwiseProduct(VectorTransformer):

@MechCoder
Copy link
Contributor Author

MechCoder commented Jun 17, 2015

ping @davies Would you be able to have a look at this?

davies
davies reviewed Jun 17, 2015
View reviewed changes
python/pyspark/mllib/feature.py Outdated
Copy link
Contributor

@davies davies Jun 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be TypeError?

Copy link
Contributor Author

@MechCoder MechCoder Jun 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. on Second thoughts, I should maybe just write

self.vector = _convert_to_vector(vector)

WDYT?

Copy link
Contributor

@davies davies Jun 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@MechCoder
Copy link
Contributor Author

MechCoder commented Jun 17, 2015

@davies I fixed your comments and replaced vector with scalingVector for consistency

@SparkQA
Copy link

SparkQA commented Jun 17, 2015

Test build #35059 has finished for PR 6346 at commit 79d1ef5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ElementwiseProduct(VectorTransformer):

@davies
Copy link
Contributor

davies commented Jun 18, 2015

LGTM, merging into master!

@asfgit asfgit closed this in 22732e1 Jun 18, 2015
@MechCoder
Copy link
Contributor Author

MechCoder commented Jun 18, 2015

@davies Thanks. Do you want me to look at any particular PR if it needs reviews?

@MechCoder MechCoder deleted the spark-7605 branch June 18, 2015 05:10
@davies
Copy link
Contributor

davies commented Jun 18, 2015

Any comments on any PR or JIRA are welcome, thanks!

jkbradley
jkbradley reviewed Jun 18, 2015
View reviewed changes
docs/mllib-feature-extraction.md
Copy link
Member

@jkbradley jkbradley Jun 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to set up SparkContext for an example here. I prefer to be able to copy and paste code into the pyspark shell for testing.

@jkbradley
Copy link
Member

jkbradley commented Jun 18, 2015

Oh, I see this was merged already. @MechCoder I'm updating some docs, so I'll include those comments in my next patch. Thanks for the PR!

nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@MechCoder @nemccarthy
[SPARK-7605] [MLLIB] [PYSPARK] Python API for ElementwiseProduct
c8f3d5d 
Python API for org.apache.spark.mllib.feature.ElementwiseProduct

Author: MechCoder <manojkumarsivaraj334@gmail.com>

Closes apache#6346 from MechCoder/spark-7605 and squashes the following commits:

79d1ef5 [MechCoder] Consistent and support list / array types
5f81d81 [MechCoder] [SPARK-7605] [MLlib] Python API for ElementwiseProduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MechCoder @SparkQA @davies @jkbradley