[SPARK-7809][MLlib] Add computation configure for MultivariateOnlineSummarizer #6388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #33435 has finished for PR 6388 at commit
|
|
Test build #33436 timed out for PR 6388 at commit |
Member
Author
|
retest this please. |
|
Test build #33446 has finished for PR 6388 at commit
|
Member
There was a problem hiding this comment.
since we are using setter in ml Params, let's call it
setWithMean
Member
There was a problem hiding this comment.
also, i am not really sure if mutable map is a good approach here since it's not type safe.
Member
There was a problem hiding this comment.
since in the tight loop, you are checking the condition all the time, let's not use map, but use primitive type for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/SPARK-7809