Skip to content

Conversation

@yanboliang
Copy link
Contributor

Check then make the MLlib Python classification and regression doc to be as complete as the Scala doc.

@SparkQA
Copy link

SparkQA commented May 28, 2015

Test build #33663 has finished for PR 6460 at commit 3eaf6ad.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KryoSerializationStream(
    • class KryoDeserializationStream(

@yanboliang yanboliang changed the title [SPARK-7916] [MLlib] [Doc] MLlib Python doc parity check for classification and regression [SPARK-7916] [MLlib] MLlib Python doc parity check for classification and regression May 29, 2015
@yanboliang
Copy link
Contributor Author

The length of docstring line for PEP8 standard is 72, so truncate too long line.

@SparkQA
Copy link

SparkQA commented May 30, 2015

Test build #33805 has finished for PR 6460 at commit ce2a43e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not say "with no regularization." It looks like this is a difference between the Python & Scala APIs.

@jkbradley
Copy link
Member

@yanboliang Thanks for adding this doc! With so many Python users, this should be very helpful.

@SparkQA
Copy link

SparkQA commented Jun 15, 2015

Test build #34932 has finished for PR 6460 at commit 6dc4d99.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 16, 2015

Test build #34968 has finished for PR 6460 at commit f8deda4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

This LGTM I'll merge it into master and branch-1.4

@yanboliang Thanks for the PR, and sorry about the delay in merging! We can update the docs on the website at any time, thankfully, so this should be able to go up once some other updates get in as well.

asfgit pushed a commit that referenced this pull request Jun 16, 2015
… and regression

Check then make the MLlib Python classification and regression doc to be as complete as the Scala doc.

Author: Yanbo Liang <ybliang8@gmail.com>

Closes #6460 from yanboliang/spark-7916 and squashes the following commits:

f8deda4 [Yanbo Liang] trigger jenkins
6dc4d99 [Yanbo Liang] address comments
ce2a43e [Yanbo Liang] truncate too long line and remove extra sparse
3eaf6ad [Yanbo Liang] MLlib Python doc parity check for classification and regression

(cherry picked from commit ca99875)
Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
@asfgit asfgit closed this in ca99875 Jun 16, 2015
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
… and regression

Check then make the MLlib Python classification and regression doc to be as complete as the Scala doc.

Author: Yanbo Liang <ybliang8@gmail.com>

Closes apache#6460 from yanboliang/spark-7916 and squashes the following commits:

f8deda4 [Yanbo Liang] trigger jenkins
6dc4d99 [Yanbo Liang] address comments
ce2a43e [Yanbo Liang] truncate too long line and remove extra sparse
3eaf6ad [Yanbo Liang] MLlib Python doc parity check for classification and regression
@yanboliang yanboliang deleted the spark-7916 branch June 26, 2015 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants