Skip to content

SPARK-8078 #6611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yang1young wants to merge 1 commit into from
Closed

SPARK-8078 #6611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,12 @@ object DecisionTree extends Serializable with Logging {
val leftWeight = leftCount / totalCount.toDouble
val rightWeight = rightCount / totalCount.toDouble

val gain = impurity - leftWeight * leftImpurity - rightWeight * rightImpurity
val gainRatio = impurity - leftWeight * leftImpurity - rightWeight * rightImpurity
//calculate splitInfo
Copy link
Member

@srowen srowen Jun 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these lines don't match the project code style. Please read https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark

val splitInfo= -(scala.math.log(leftCount/totalCount.toDouble)
+scala.math.log(rightCount/totalCount.toDouble))/scala.math.log(2)
//C4.5 algorithm instead of ID3 algorithm
val gain=gainRatio/splitInfo

// if information gain doesn't satisfy minimum information gain,
// then this split is invalid, return invalid information gain stats.
Expand Down