Skip to content

[SPARK-1754] [SQL] Add missing arithmetic DSL operations. #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ueshin wants to merge 4 commits into from
Closed

[SPARK-1754] [SQL] Add missing arithmetic DSL operations. #689

ueshin wants to merge 4 commits into from

Conversation

@ueshin
Copy link
Member

@ueshin ueshin commented May 8, 2014

Add missing arithmetic DSL operations: unary_-, %.

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14803/

marmbrus
marmbrus reviewed May 8, 2014
View reviewed changes
...yst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvaluationSuite.scala Outdated
Copy link
Contributor

@marmbrus marmbrus May 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these predicate tests are redundant with the tests above.

Copy link
Member Author

@ueshin ueshin May 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comment.
I just wanted to check if the DSL operations work or not here.
Don't we need them?

Copy link
Contributor

@marmbrus marmbrus May 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests above use the DSL too and test the whole truth table for each operation.

Copy link
Member Author

@ueshin ueshin May 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, you are right.
I'll remove the test.

@marmbrus
Copy link
Contributor

marmbrus commented May 8, 2014

Thanks for doing this! I think we are also missing ! (not).

@ueshin
Copy link
Member Author

ueshin commented May 8, 2014

Oops, I'll add it.

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14806/

asfgit pushed a commit that referenced this pull request May 8, 2014
@ueshin @pwendell
[SPARK-1754] [SQL] Add missing arithmetic DSL operations.
6f701ff 
Add missing arithmetic DSL operations: `unary_-`, `%`.

Author: Takuya UESHIN <ueshin@happy-camper.st>

Closes #689 from ueshin/issues/SPARK-1754 and squashes the following commits:

a09ef69 [Takuya UESHIN] Add also missing ! (not) operation.
f73ae2c [Takuya UESHIN] Remove redundant tests.
5b3f087 [Takuya UESHIN] Add tests relating DSL operations.
e09c5b8 [Takuya UESHIN] Add missing arithmetic DSL operations.
(cherry picked from commit 322b180)

Signed-off-by: Patrick Wendell <pwendell@gmail.com>
@asfgit asfgit closed this in 322b180 May 8, 2014
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
@ueshin @pdeyhim
[SPARK-1754] [SQL] Add missing arithmetic DSL operations.
7daa282 
Add missing arithmetic DSL operations: `unary_-`, `%`.

Author: Takuya UESHIN <ueshin@happy-camper.st>

Closes apache#689 from ueshin/issues/SPARK-1754 and squashes the following commits:

a09ef69 [Takuya UESHIN] Add also missing ! (not) operation.
f73ae2c [Takuya UESHIN] Remove redundant tests.
5b3f087 [Takuya UESHIN] Add tests relating DSL operations.
e09c5b8 [Takuya UESHIN] Add missing arithmetic DSL operations.
agirish pushed a commit to HPEEzmeral/apache-spark that referenced this pull request May 5, 2022
@ekrivokonmapr
MapR [SPARK-755] Spark build failed because of using banned dependenc…
94660f3 
…ies (apache#689)
udaynpusa pushed a commit to mapr/spark that referenced this pull request Jan 30, 2024
@ekrivokonmapr
MapR [SPARK-755] Spark build failed because of using banned dependenc…
6bd6d68 
…ies (apache#689)
mapr-devops pushed a commit to mapr/spark that referenced this pull request May 8, 2025
@ekrivokonmapr
MapR [SPARK-755] Spark build failed because of using banned dependenc…
6b8e90c 
…ies (apache#689)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ueshin @AmplabJenkins @marmbrus