L-BFGS Documentation#702
L-BFGS Documentation#702dbtsai wants to merge 5 commits intoapache:masterfrom dbtsai:dbtsai-lbfgs-doc
Conversation
|
Merged build triggered. |
|
Merged build started. |
docs/mllib-optimization.md
Outdated
There was a problem hiding this comment.
Either L-BFGS or The L-BFGS method.
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14829/ |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build triggered. |
|
Merged build started. |
docs/mllib-optimization.md
Outdated
There was a problem hiding this comment.
appendBias puts 1.0 at the end of the vector. So the slicing here needs update.
There was a problem hiding this comment.
Why don't we have prependOne in the MLUtils as well? Due to the scope, users can not use prependOne. It's more intuitive to have intercept as first element.
|
Merged build finished. All automated tests passed. |
|
Merged build finished. |
|
All automated tests passed. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14860/ |
docs/mllib-optimization.md
Outdated
There was a problem hiding this comment.
This is the first time L-BFGS appears in the guide. So let us use Limited-memory BFGS (L-BFGS). Well, it is not necessary to explain BFGS ..
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
|
LGTM. Thanks! |
|
I've merged this. Thanks. |
Documentation for L-BFGS, and an example of training binary L2 logistic regression using L-BFGS. Author: DB Tsai <dbtsai@alpinenow.com> Closes #702 from dbtsai/dbtsai-lbfgs-doc and squashes the following commits: 0712215 [DB Tsai] Update 38fdfa1 [DB Tsai] Removed extra empty line 5745b64 [DB Tsai] Update again e9e418e [DB Tsai] Update 7381521 [DB Tsai] L-BFGS Documentation (cherry picked from commit 5c2275d) Signed-off-by: Reynold Xin <rxin@apache.org>
Documentation for L-BFGS, and an example of training binary L2 logistic regression using L-BFGS. Author: DB Tsai <dbtsai@alpinenow.com> Closes apache#702 from dbtsai/dbtsai-lbfgs-doc and squashes the following commits: 0712215 [DB Tsai] Update 38fdfa1 [DB Tsai] Removed extra empty line 5745b64 [DB Tsai] Update again e9e418e [DB Tsai] Update 7381521 [DB Tsai] L-BFGS Documentation
…#702) * Add failing test * More generously infer columns as strings if Arrow thought they are binary * Add failing test for true binary values * Infer 'mixed' columns by checking the first value * Update FORK.md
4 participants
Documentation for L-BFGS, and an example of training binary L2 logistic regression using L-BFGS.