[SPARK-8915] [Documentation, MLlib] Added @since tags to mllib.classification #7371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ok to test |
Contributor
|
@dbtsai Could you help review this PR? |
Contributor
There was a problem hiding this comment.
We only put @since on public classes and methods. This is a package private method. So it is not necessary to add @since tag.
Member
|
@mengxr Sure. I will take over. Thanks. |
|
Test build #37137 has finished for PR 7371 at commit
|
|
Test build #37223 has finished for PR 7371 at commit
|
Member
|
LGTM except minor formatting issue. |
|
Test build #37946 has finished for PR 7371 at commit
|
Contributor
|
Merged into master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created since tags for methods in mllib.classification