Merge addWithoutResize and rehashIfNeeded into one function.#738
Closed
ArcherShao wants to merge 1 commit intoapache:masterfrom
ArcherShao:branch_graphx
Closed
Merge addWithoutResize and rehashIfNeeded into one function.#738ArcherShao wants to merge 1 commit intoapache:masterfrom ArcherShao:branch_graphx
ArcherShao wants to merge 1 commit intoapache:masterfrom
ArcherShao:branch_graphx
Conversation
|
Can one of the admins verify this patch? |
Contributor
|
Thanks for submitting this - but considering this is a low level building block collection and not meant to be used as a general collection library, and the method's name itself is very obvious that it doesn't do resizing, I am not sure if it is worth changing them at this point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will be more safety to add an element, users do not need to the function rehashIfNeeded() after addWithoutResize().