Skip to content

SPARK-1803 Replaced colon in filenames with a dash#739

Closed
sslavic wants to merge 18 commits intoapache:masterfrom
sslavic:SPARK-1803
Closed

SPARK-1803 Replaced colon in filenames with a dash#739
sslavic wants to merge 18 commits intoapache:masterfrom
sslavic:SPARK-1803

Conversation

@sslavic
Copy link
Member

@sslavic sslavic commented May 12, 2014

This patch replaces colon in several filenames with dash to make these filenames Windows compatible.

sslavic added 16 commits May 12, 2014 16:25
This patch replaces colon in file name with dash to make file name Windows compatible.
This patch replaces colon in file name with dash to make file name Windows compatible.
This patch replaces colon in file name with dash to make file name Windows compatible.
This patch replaces colon in file name with dash to make file name Windows compatible.
This patch replaces colon in file name with dash to make file name Windows compatible.
This patch replaces colon in file name with dash to make file name Windows compatible.
This patch replaces colon in file name with dash to make file name Windows compatible.
This patch replaces colon in file name with dash to make file name Windows compatible.
This patch replaces colon in file name with dash to make file name Windows compatible.
This patch replaces colon in file name with dash to make file name Windows compatible.
This patch replaces colon in file name with dash to make file name Windows compatible.
This patch replaces colon in file name with dash to make file name Windows compatible.
This patch replaces colon in file name with dash to make file name Windows compatible.
This patch replaces colon in file name with dash to make file name Windows compatible.
This patch replaces colon in file name with dash to make file name Windows compatible.
This patch fixes a typo in file name - 'Partiton' is replaced with 'Partition'.
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@rxin
Copy link
Contributor

rxin commented May 13, 2014

Jenkins, test this please.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished.

@AmplabJenkins
Copy link

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14925/

This patch replaces colon in test name with dash to make test name match test file name, which were renamed for Windows compatibility.
@rxin
Copy link
Contributor

rxin commented May 14, 2014

Jenkins, retest this please.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished.

@AmplabJenkins
Copy link

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14958/

@sslavic
Copy link
Member Author

sslavic commented May 14, 2014

Jenkins, retest this please.

@marmbrus
Copy link
Contributor

test this please

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15000/

@sslavic
Copy link
Member Author

sslavic commented May 15, 2014

Nice, tests passed. Please consider merging, maybe even for 1.0 release.

@rxin
Copy link
Contributor

rxin commented May 15, 2014

Thanks. I've merged this into master & branch-1.0.

@asfgit asfgit closed this in e66e31b May 15, 2014
asfgit pushed a commit that referenced this pull request May 15, 2014
This patch replaces colon in several filenames with dash to make these filenames Windows compatible.

Author: Stevo Slavić <sslavic@gmail.com>
Author: Stevo Slavic <sslavic@gmail.com>

Closes #739 from sslavic/SPARK-1803 and squashes the following commits:

3ec66eb [Stevo Slavic] Removed extra empty line which was causing test to fail
b967cc3 [Stevo Slavić] Aligned tests and names of test resources
2b12776 [Stevo Slavić] Fixed a typo in file name
1c5dfff [Stevo Slavić] Replaced colon in file name with dash
8f5bf7f [Stevo Slavić] Replaced colon in file name with dash
c5b5083 [Stevo Slavić] Replaced colon in file name with dash
a49801f [Stevo Slavić] Replaced colon in file name with dash
401d99e [Stevo Slavić] Replaced colon in file name with dash
40a9621 [Stevo Slavić] Replaced colon in file name with dash
4774580 [Stevo Slavić] Replaced colon in file name with dash
004f8bb [Stevo Slavić] Replaced colon in file name with dash
d6a3e2c [Stevo Slavić] Replaced colon in file name with dash
b585126 [Stevo Slavić] Replaced colon in file name with dash
028e48a [Stevo Slavić] Replaced colon in file name with dash
ece0507 [Stevo Slavić] Replaced colon in file name with dash
84f5d2f [Stevo Slavić] Replaced colon in file name with dash
2fc7854 [Stevo Slavić] Replaced colon in file name with dash
9e1467d [Stevo Slavić] Replaced colon in file name with dash

(cherry picked from commit e66e31b)
Signed-off-by: Reynold Xin <rxin@apache.org>
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
This patch replaces colon in several filenames with dash to make these filenames Windows compatible.

Author: Stevo Slavić <sslavic@gmail.com>
Author: Stevo Slavic <sslavic@gmail.com>

Closes apache#739 from sslavic/SPARK-1803 and squashes the following commits:

3ec66eb [Stevo Slavic] Removed extra empty line which was causing test to fail
b967cc3 [Stevo Slavić] Aligned tests and names of test resources
2b12776 [Stevo Slavić] Fixed a typo in file name
1c5dfff [Stevo Slavić] Replaced colon in file name with dash
8f5bf7f [Stevo Slavić] Replaced colon in file name with dash
c5b5083 [Stevo Slavić] Replaced colon in file name with dash
a49801f [Stevo Slavić] Replaced colon in file name with dash
401d99e [Stevo Slavić] Replaced colon in file name with dash
40a9621 [Stevo Slavić] Replaced colon in file name with dash
4774580 [Stevo Slavić] Replaced colon in file name with dash
004f8bb [Stevo Slavić] Replaced colon in file name with dash
d6a3e2c [Stevo Slavić] Replaced colon in file name with dash
b585126 [Stevo Slavić] Replaced colon in file name with dash
028e48a [Stevo Slavić] Replaced colon in file name with dash
ece0507 [Stevo Slavić] Replaced colon in file name with dash
84f5d2f [Stevo Slavić] Replaced colon in file name with dash
2fc7854 [Stevo Slavić] Replaced colon in file name with dash
9e1467d [Stevo Slavić] Replaced colon in file name with dash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants