Skip to content

Conversation

@tdas
Copy link
Contributor

@tdas tdas commented Jul 15, 2015

Current Kinesis unit tests do not test createStream by sending data. This PR is to add such unit test. Note that this unit will not run by default. It will only run when the relevant environment variables are set.

@SparkQA
Copy link

SparkQA commented Jul 15, 2015

Test build #37317 has finished for PR 7413 at commit 0924c43.

  • This patch fails RAT tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KinesisTestUtils(val endpointUrl: String, _regionName: String = "") extends Logging

@SparkQA
Copy link

SparkQA commented Jul 15, 2015

Test build #37318 has finished for PR 7413 at commit d38cf2e.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KinesisTestUtils(val endpointUrl: String, _regionName: String = "") extends Logging

@tdas
Copy link
Contributor Author

tdas commented Jul 16, 2015

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Jul 16, 2015

Test build #37445 has finished for PR 7413 at commit c6be0d7.

  • This patch fails RAT tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 16, 2015

Test build #37447 has finished for PR 7413 at commit dbb33a5.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tdas
Copy link
Contributor Author

tdas commented Jul 16, 2015

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Jul 16, 2015

Test build #37457 has finished for PR 7413 at commit 18c2208.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 16, 2015

Test build #37472 has finished for PR 7413 at commit deb7f4f.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 16, 2015

Test build #37477 has finished for PR 7413 at commit a297b59.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line

@zsxwing
Copy link
Member

zsxwing commented Jul 16, 2015

Thanks @tdas I'm not familiar with Kinesis client APIs. But generally looks good and Jenkins is green. I will add Python tests for the Kinesis Python API after this PR is merged.

@SparkQA
Copy link

SparkQA commented Jul 17, 2015

Test build #37611 has finished for PR 7413 at commit c7caef7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tdas
Copy link
Contributor Author

tdas commented Jul 17, 2015

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Jul 17, 2015

Test build #37622 has finished for PR 7413 at commit 0e16db5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Jul 17, 2015

LGTM

@tdas tdas changed the title [SPARK-9030][STREAMING][WIP] Add Kinesis.createStream unit tests that actual sends data [SPARK-9030][STREAMING] Add Kinesis.createStream unit tests that actual sends data Jul 17, 2015
@tdas
Copy link
Contributor Author

tdas commented Jul 17, 2015

Thanks @zsxwing, merging this to master.

@asfgit asfgit closed this in b13ef77 Jul 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants